From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id CBBEA6B0078 for ; Wed, 8 Jun 2011 17:10:31 -0400 (EDT) Date: Wed, 8 Jun 2011 14:09:51 -0700 From: Andrew Morton Subject: Re: [PATCH] memcg: do not expose uninitialized mem_cgroup_per_node to world Message-Id: <20110608140951.115ab1dd.akpm@linux-foundation.org> In-Reply-To: <20110608123527.479e6991.kamezawa.hiroyu@jp.fujitsu.com> References: <1306925044-2828-1-git-send-email-imammedo@redhat.com> <20110601123913.GC4266@tiehlicka.suse.cz> <4DE6399C.8070802@redhat.com> <20110601134149.GD4266@tiehlicka.suse.cz> <4DE64F0C.3050203@redhat.com> <20110601152039.GG4266@tiehlicka.suse.cz> <4DE66BEB.7040502@redhat.com> <4DE8D50F.1090406@redhat.com> <4DEE26E7.2060201@redhat.com> <20110608123527.479e6991.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: Igor Mammedov , Hiroyuki Kamezawa , Michal Hocko , linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, linux-mm@kvack.org, Paul Menage , Li Zefan , containers@lists.linux-foundation.org The original patch: --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4707,7 +4707,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) if (!pn) return 1; - mem->info.nodeinfo[node] = pn; for (zone = 0; zone < MAX_NR_ZONES; zone++) { mz = &pn->zoneinfo[zone]; for_each_lru(l) @@ -4716,6 +4715,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) mz->on_tree = false; mz->mem = mem; } + mem->info.nodeinfo[node] = pn; return 0; } looks like a really good idea. But it needs a new changelog and I'd be a bit reluctant to merge it as it appears that the aptch removes our only known way of reproducing a bug. So for now I think I'll queue the patch up unchangelogged so the issue doesn't get forgotten about. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org