From: Mel Gorman <mgorman@suse.de>
To: Micha? Miros?aw <mirqus@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>, Neil Brown <neilb@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing
Date: Thu, 9 Jun 2011 12:35:05 +0100 [thread overview]
Message-ID: <20110609113505.GR5247@suse.de> (raw)
In-Reply-To: <BANLkTimUE9yb-DegdUk0BbbOGWoUhEBrqw@mail.gmail.com>
On Thu, Jun 09, 2011 at 12:21:31PM +0200, Micha? Miros?aw wrote:
> 2011/6/9 Mel Gorman <mgorman@suse.de>:
> [...]
> > +/*
> > + * Limit which protocols can use the PFMEMALLOC reserves to those that are
> > + * expected to be used for communication with swap.
> > + */
> > +static bool skb_pfmemalloc_protocol(struct sk_buff *skb)
> > +{
> > + switch (skb->protocol) {
> > + case __constant_htons(ETH_P_ARP):
> > + case __constant_htons(ETH_P_IP):
> > + case __constant_htons(ETH_P_IPV6):
> > + case __constant_htons(ETH_P_8021Q):
> > + return true;
> > + default:
> > + return false;
> > + }
> > +}
>
> This is not needed and wrong. Whatever list there will be, it's going
> to always miss some obscure setup (or not that obscure, like
> ATAoverEthernet).
>
NBD is updated in the series to set the socket information
appropriately but the same cannot be said of AoE. The necessary
changes have been made IPv4 and IPv6 to handle pfmemalloc sockets
but the same cannot be necessarily said for the other protocols. Yes,
the check could be removed but leaving it there makes a clear statement
on what scenario can be reasonably expected to work.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-09 11:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 8:02 [PATCH 00/14] Swap-over-NBD without deadlocking v4r3 Mel Gorman
2011-06-09 8:02 ` [PATCH 01/14] mm: Serialize access to min_free_kbytes Mel Gorman
2011-06-09 8:02 ` [PATCH 02/14] mm: sl[au]b: Add knowledge of PFMEMALLOC reserve pages Mel Gorman
2011-06-09 8:02 ` [PATCH 03/14] mm: Introduce __GFP_MEMALLOC to allow access to emergency reserves Mel Gorman
2011-06-09 8:02 ` [PATCH 04/14] mm: allow PF_MEMALLOC from softirq context Mel Gorman
2011-06-09 8:02 ` [PATCH 05/14] mm: Ignore mempolicies when using ALLOC_NO_WATERMARK Mel Gorman
2011-06-09 8:02 ` [PATCH 06/14] net: Introduce sk_allocation() to allow addition of GFP flags depending on the individual socket Mel Gorman
2011-06-09 8:02 ` [PATCH 07/14] netvm: Allow the use of __GFP_MEMALLOC by specific sockets Mel Gorman
2011-06-09 8:02 ` [PATCH 08/14] netvm: Allow skb allocation to use PFMEMALLOC reserves Mel Gorman
2011-06-09 8:02 ` [PATCH 09/14] netvm: Propagate page->pfmemalloc to skb Mel Gorman
2011-06-09 8:02 ` [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
2011-06-09 10:21 ` Michał Mirosław
2011-06-09 11:35 ` Mel Gorman [this message]
2011-06-09 12:28 ` Michał Mirosław
2011-06-09 12:56 ` Mel Gorman
2011-06-09 8:02 ` [PATCH 11/14] mm: Micro-optimise slab to avoid a function call Mel Gorman
2011-06-09 8:02 ` [PATCH 12/14] nbd: Set SOCK_MEMALLOC for access to PFMEMALLOC reserves Mel Gorman
2011-06-09 8:02 ` [PATCH 13/14] mm: Throttle direct reclaimers if PF_MEMALLOC reserves are low and swap is backed by network storage Mel Gorman
2011-06-09 8:02 ` [PATCH 14/14] mm: Account for the number of times direct reclaimers get throttled Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2011-06-20 13:12 [PATCH 00/14] Swap-over-NBD without deadlocking v5 Mel Gorman
2011-06-20 13:12 ` [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
2011-09-09 10:57 [PATCH 00/14] Swap-over-NBD without deadlocking v6 Mel Gorman
2011-09-09 10:57 ` [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
2011-10-06 12:41 [PATCH 00/14] Swap-over-NBD without deadlocking V7 Mel Gorman
2011-10-06 12:41 ` [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609113505.GR5247@suse.de \
--to=mgorman@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mirqus@gmail.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).