From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 51B546B0012 for ; Tue, 14 Jun 2011 05:48:20 -0400 (EDT) Date: Tue, 14 Jun 2011 11:48:11 +0200 From: Johannes Weiner Subject: Re: [BUGFIX][PATCH 4/5] memcg: fix wrong check of noswap with softlimit Message-ID: <20110614094811.GD6371@redhat.com> References: <20110613120054.3336e997.kamezawa.hiroyu@jp.fujitsu.com> <20110613121105.b8f251e2.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110613121105.b8f251e2.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "nishimura@mxp.nes.nec.co.jp" , "bsingharora@gmail.com" , "hannes@cmpxchg.org" , Michal Hocko , Ying Han On Mon, Jun 13, 2011 at 12:11:05PM +0900, KAMEZAWA Hiroyuki wrote: > >From 0a0358d300330a4ba86e39ea56ed63f1e4519dfd Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki > Date: Mon, 13 Jun 2011 10:31:16 +0900 > Subject: [PATCH 4/5] fix wrong check of noswap with softlimit > > Hierarchical reclaim doesn't swap out if memsw and resource limits are > same (memsw_is_minimum == true) because we would hit mem+swap limit > anyway (during hard limit reclaim). > If it comes to the solft limit we shouldn't consider memsw_is_minimum at > all because it doesn't make much sense. Either the soft limit is bellow > the hard limit and then we cannot hit mem+swap limit or the direct > reclaim takes a precedence. > > Reviewed-by: Michal Hocko > Acked-by: Daisuke Nishimura > Signed-off-by: KAMEZAWA Hiroyuki Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org