From: Randy Dunlap <rdunlap@xenotime.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] fix cleancache config
Date: Sun, 19 Jun 2011 19:07:46 -0700 [thread overview]
Message-ID: <20110619190746.457544f1.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110619215026.GA17202@infradead.org>
On Sun, 19 Jun 2011 17:50:26 -0400 Christoph Hellwig wrote:
> On Sun, Jun 19, 2011 at 05:29:55PM +0200, Rolf Eike Beer wrote:
> > >From 2b3ebe8ffd22793dc53f4b7301048d60e8db017e Mon Sep 17 00:00:00 2001
> > From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> > Date: Thu, 9 Jun 2011 14:13:58 +0200
> > Subject: [PATCH] fix cleancache config
> >
> > It doesn't make sense to have a default setting different to that what we
> > suggest the user to select. Also fixes a typo.
>
> NAK
>
> default y is not for random crap, but for essential bits that should
> only be explicitly disabled if you really know what you do.
I.e., please change the last line of CLEANCACHE help text in mm/Kconfig.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-20 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 15:29 [PATCH] fix cleancache config Rolf Eike Beer
2011-06-19 21:50 ` Christoph Hellwig
2011-06-20 2:07 ` Randy Dunlap [this message]
2011-06-20 6:06 ` Rolf Eike Beer
-- strict thread matches above, loose matches on Subject: below --
2011-06-24 1:12 Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619190746.457544f1.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=eike-kernel@sf-tec.de \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).