[PATCH] fix cleancache config

[PATCH] fix cleancache config

[Rolf Eike Beer]

Re: [PATCH] fix cleancache config

[Christoph Hellwig]

On Sun, Jun 19, 2011 at 05:29:55PM +0200, Rolf Eike Beer wrote:
> >From 2b3ebe8ffd22793dc53f4b7301048d60e8db017e Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> Date: Thu, 9 Jun 2011 14:13:58 +0200
> Subject: [PATCH] fix cleancache config
> 
> It doesn't make sense to have a default setting different to that what we
> suggest the user to select. Also fixes a typo.

NAK

default y is not for random crap, but for essential bits that should
only be explicitly disabled if you really know what you do.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] fix cleancache config

[Randy Dunlap]

On Sun, 19 Jun 2011 17:50:26 -0400 Christoph Hellwig wrote:

> On Sun, Jun 19, 2011 at 05:29:55PM +0200, Rolf Eike Beer wrote:
> > >From 2b3ebe8ffd22793dc53f4b7301048d60e8db017e Mon Sep 17 00:00:00 2001
> > From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> > Date: Thu, 9 Jun 2011 14:13:58 +0200
> > Subject: [PATCH] fix cleancache config
> > 
> > It doesn't make sense to have a default setting different to that what we
> > suggest the user to select. Also fixes a typo.
> 
> NAK
> 
> default y is not for random crap, but for essential bits that should
> only be explicitly disabled if you really know what you do.


I.e., please change the last line of CLEANCACHE help text in mm/Kconfig.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] fix cleancache config

[Rolf Eike Beer]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

Christoph Hellwig wrote:
> On Sun, Jun 19, 2011 at 05:29:55PM +0200, Rolf Eike Beer wrote:
> > >From 2b3ebe8ffd22793dc53f4b7301048d60e8db017e Mon Sep 17 00:00:00 2001
> > 
> > From: Rolf Eike Beer <eike-kernel@sf-tec.de>
> > Date: Thu, 9 Jun 2011 14:13:58 +0200
> > Subject: [PATCH] fix cleancache config
> > 
> > It doesn't make sense to have a default setting different to that what
> > we
> > suggest the user to select. Also fixes a typo.
> 
> NAK
> 
> default y is not for random crap, but for essential bits that should
> only be explicitly disabled if you really know what you do.

So you want the user to enable this if he reads the help text but not to 
enable this when he does not? This is totally senseless.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] fix cleancache config

[Dan Magenheimer]

> It doesn't make sense to have a default setting different to that what we
> suggest the user to select.

Even when configured on at compile time, cleancache functionality
is inert unless the hooks are registered by a "backend" (e.g.
zcache or Xen or other future code).   If configured on,
a backend module can dynamically enable cleancache functionality;
the cost is extremely small, so all postings of cleancache
had "default y".

Just before Linus merged cleancache, he insisted that the
default be changed to "n".  I didn't argue, just changed it.
However, I think in the future most distros will prefer to
have it set so the functionality can be enabled at runtime,
thus the help comment is inconsistent with the default.

> Also fixes a typo.

Don't know how I missed that one :-}  Typo fix:

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>

Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>