linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: P?draig Brady <P@draigBrady.com>
Cc: linux-mm@kvack.org
Subject: Re: sandy bridge kswapd0 livelock with pagecache
Date: Tue, 21 Jun 2011 15:34:34 +0100	[thread overview]
Message-ID: <20110621143434.GI9396@suse.de> (raw)
In-Reply-To: <4E008784.80107@draigBrady.com>

On Tue, Jun 21, 2011 at 12:59:00PM +0100, P?draig Brady wrote:
> On 21/06/11 12:34, Mel Gorman wrote:
> > On Tue, Jun 21, 2011 at 11:47:35AM +0100, P?draig Brady wrote:
> >> On 21/06/11 11:39, Mel Gorman wrote:
> >>> On Tue, Jun 21, 2011 at 10:53:02AM +0100, P?draig Brady wrote:
> >>>> I tried the 2 patches here to no avail:
> >>>> http://marc.info/?l=linux-mm&m=130503811704830&w=2
> >>>>
> >>>> I originally logged this at:
> >>>> https://bugzilla.redhat.com/show_bug.cgi?id=712019
> >>>>
> >>>> I can compile up and quickly test any suggestions.
> >>>>
> >>>
> >>> I recently looked through what kswapd does and there are a number
> >>> of problem areas. Unfortunately, I haven't gotten around to doing
> >>> anything about it yet or running the test cases to see if they are
> >>> really problems. In your case, the following is a strong possibility
> >>> though. This should be applied on top of the two patches merged from
> >>> that thread.
> >>>
> >>> This is not tested in any way, based on 3.0-rc3
> >>
> >> This does not fix the issue here.
> >>
> > 
> > I made a silly mistake here.  When you mentioned two patches applied,
> > I assumed you meant two patches that were finally merged from that
> > discussion thread instead of looking at your linked mail. Now that I
> > have checked, I think you applied the SLUB patches while the patches
> > I was thinking of are;
> > 
> > [afc7e326: mm: vmscan: correct use of pgdat_balanced in sleeping_prematurely]
> > [f06590bd: mm: vmscan: correctly check if reclaimer should schedule during shrink_slab]
> > 
> > The first one in particular has been reported by another user to fix
> > hangs related to copying large files. I'm assuming you are testing
> > against the Fedora kernel. As these patches were merged for 3.0-rc1, can
> > you check if applying just these two patches to your kernel helps?
> 
> These patches are already present in my 2.6.38.8-32.fc15.x86_64 kernel :(
> 

While doing a review of patches for unrelated reasons between 2.6.38
and 3.0-rc3, I noted a few patches related to high CPU usage that may
not have made it to the Fedora kernel.

* d527caf2 mm: compaction: prevent kswapd compacting memory to reduce CPU usage
  8afdcece mm: vmscan: kswapd should not free an excessive number of pages when balancing small zones
  602605a4 mm: compaction: minimise the time IRQs are disabled while isolating free pages
  b2eef8c0 mm: compaction: minimise the time IRQs are disabled while isolating pages for migration
* 929bea7c vmscan: all_unreclaimable() use zone->all_unreclaimable as a name
* afc7e326 mm: vmscan: correct use of pgdat_balanced in sleeping_prematurely
* f06590bd mm: vmscan: correctly check if reclaimer should schedule during shrink_slab

The ones marked * are already in 2.6.38.8 so presumably in the Fedora
kernel as well but worth double checking. Of the remaining patches,
patch 2 is the most relevant to your problem as it was explicitly
targeted at reclaiming during copying large amounts of data.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-06-21 14:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21  9:53 sandy bridge kswapd0 livelock with pagecache Pádraig Brady
2011-06-21 10:39 ` Mel Gorman
2011-06-21 10:47   ` Pádraig Brady
2011-06-21 11:34     ` Mel Gorman
2011-06-21 11:59       ` Pádraig Brady
2011-06-21 13:07         ` Mel Gorman
2011-06-21 14:23           ` Pádraig Brady
2011-06-22  9:44             ` Mel Gorman
2011-06-22 10:19               ` Pádraig Brady
2011-06-23 11:46                 ` Mel Gorman
2011-06-23 13:04                   ` Pádraig Brady
2011-06-23 15:24                     ` Mel Gorman
2011-06-23 15:32                       ` Pádraig Brady
2011-06-23 16:59                         ` Mel Gorman
2011-06-23 19:25                           ` Pádraig Brady
2011-06-24 11:44                             ` Mel Gorman
2011-06-24 13:10                               ` Pádraig Brady
2011-06-24 15:04                                 ` Mel Gorman
2011-06-24  6:33             ` Shaohua Li
2011-06-21 14:34         ` Mel Gorman [this message]
2011-06-21 15:29           ` Pádraig Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621143434.GI9396@suse.de \
    --to=mgorman@suse.de \
    --cc=P@draigBrady.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).