From: Christoph Hellwig <hch@infradead.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH] mm: Do not keep page locked during page fault while charging it for memcg
Date: Wed, 22 Jun 2011 08:15:16 -0400 [thread overview]
Message-ID: <20110622121516.GA28359@infradead.org> (raw)
In-Reply-To: <20110622120635.GB14343@tiehlicka.suse.cz>
> +
> + /* We have to drop the page lock here because memcg
> + * charging might block for unbound time if memcg oom
> + * killer is disabled.
> + */
> + unlock_page(vmf.page);
> + ret = mem_cgroup_newpage_charge(page, mm, GFP_KERNEL);
> + lock_page(vmf.page);
This introduces a completely poinless unlock/lock cycle for non-memcg
pagefaults. Please make sure it only happens when actually needed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-22 12:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 12:06 [PATCH] mm: Do not keep page locked during page fault while charging it for memcg Michal Hocko
2011-06-22 12:15 ` Christoph Hellwig [this message]
2011-06-22 12:32 ` [PATCH V2] " Michal Hocko
2011-06-23 6:08 ` [PATCH] memcg: unlock page before charging it. (WasRe: " KAMEZAWA Hiroyuki
2011-06-23 7:23 ` Daisuke Nishimura
2011-06-23 7:41 ` Michal Hocko
2011-06-23 8:08 ` KAMEZAWA Hiroyuki
2011-06-23 9:02 ` Michal Hocko
2011-06-23 10:01 ` [PATCH] mm: preallocate page before lock_page at filemap COW. " KAMEZAWA Hiroyuki
2011-06-23 11:58 ` Michal Hocko
2011-06-23 13:01 ` Hiroyuki Kamezawa
2011-06-23 13:23 ` Michal Hocko
2011-06-23 13:51 ` Hiroyuki Kamezawa
2011-06-24 7:57 ` Michal Hocko
2011-06-24 11:46 ` Hiroyuki Kamezawa
2011-07-12 9:48 ` Michal Hocko
2012-01-26 10:46 ` Lutz Vieweg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622121516.GA28359@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).