From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 3C8FB900194 for ; Wed, 22 Jun 2011 10:41:34 -0400 (EDT) Date: Wed, 22 Jun 2011 16:40:57 +0200 From: Andrea Arcangeli Subject: Re: [PATCH v2 2/4] mm: make the threshold of enabling THP configurable Message-ID: <20110622144057.GW20843@redhat.com> References: <1308643849-3325-1-git-send-email-amwang@redhat.com> <1308643849-3325-2-git-send-email-amwang@redhat.com> <4E015C36.2050005@redhat.com> <4E018060.3050607@redhat.com> <4E01CCED.5050609@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E01CCED.5050609@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Cong Wang Cc: David Rientjes , linux-kernel@vger.kernel.org, Andrew Morton , dave@linux.vnet.ibm.com, Mel Gorman , Benjamin Herrenschmidt , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki , linux-mm@kvack.org On Wed, Jun 22, 2011 at 07:07:25PM +0800, Cong Wang wrote: > Actually, if we move this out of kernel, to user-space, everything > you worried will be solved by just changing the user-space code. > Just add the following pseudo code into your init script, > > if [ $total_memory -lt 512 ] > then > echo never > /sys/kernel/mm/transparent_hugepage/enabled > fi By the time this script runs some app may have allocated hugepages already potentially wasting mbytes of ram and undoing the min_free_kbytes isn't possible from userland using the kernel algorithm (it is possible actually but it's not nearly as simple as the above). There's no reason to complicate things and involve userland here when a simple kernel check can get the default right without userland dependency. Plus if this user really wants THP on 512m of ram he can still enable it and run hugeadm to enable antifrag too, without the need of =force. And forcing when PSE is enabled sounds impossible to be useful (maybe with the except of nopentium being passed to the kernel ;). There is no bug here, just send that printk cleanup and if you really want to save 8k the patch to change the number of hash heads structs at boot, like for dcache/icache. No other change required. After you do the above, you can go ahead picking one kernel crashing bug and fix it, that is more useful than making this 512m thing a .config variable or anything like that, .config is a nightmare already so it's probably better not to add anything there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org