linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
	Christoph Lameter <cl@linux.com>,
	Marcin Slusarz <marcin.slusarz@gmail.com>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] slub: reduce overhead of slub_debug
Date: Tue, 28 Jun 2011 17:16:47 -0400	[thread overview]
Message-ID: <20110628211647.GB11660@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106281355010.4229@chino.kir.corp.google.com>

On Tue, Jun 28, 2011 at 01:58:06PM -0700, David Rientjes wrote:

 > SLUB debugging is useful only to diagnose issues or test new code, nobody 
 > is going to be enabling it in production environment.  We don't need 30 
 > new lines of code that make one thing slightly faster

During five of the six months of development, Fedora kernels are built with
slub debugging forced on.  And it turns up problems every single release.

Having the impact of this be lower is very desirable. If this doesn't get
merged, I'd be tempted to carry it in Fedora regardless for this reason.

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-06-28 21:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 19:39 [PATCH] slub: reduce overhead of slub_debug Marcin Slusarz
2011-06-28 19:32 ` Christoph Lameter
2011-06-28 19:40   ` David Daney
2011-06-28 20:58     ` David Rientjes
2011-06-28 21:04       ` Ben Greear
2011-06-28 21:10         ` David Rientjes
2011-06-28 21:16       ` Dave Jones [this message]
2011-07-07 18:07 ` Pekka Enberg
2011-07-07 18:17   ` Christoph Lameter
2011-07-07 18:30     ` Ben Greear
2011-07-07 18:42       ` Christoph Lameter
2011-07-07 18:54         ` Ben Greear
2011-07-07 18:30     ` Matt Mackall
2011-07-07 18:52     ` Pekka Enberg
2011-07-07 18:55       ` Matt Mackall
2011-07-07 19:12       ` Christoph Lameter
2011-07-07 19:21         ` David Miller
2011-07-07 19:49           ` Pekka Enberg
2011-07-07 20:12             ` Christoph Lameter
2011-07-08  5:23               ` Andi Kleen
2011-07-08 17:41                 ` Christoph Lameter
2011-07-08  5:38               ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110628211647.GB11660@redhat.com \
    --to=davej@redhat.com \
    --cc=cl@linux.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).