From: Andrea Arcangeli <aarcange@redhat.com>
To: Nai Xia <nai.xia@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, Marcelo Tosatti <mtosatti@redhat.com>,
Johannes Weiner <jweiner@redhat.com>
Subject: Re: mm: do_wp_page recheck PageKsm after obtaining the page_lock, pte_same not enough
Date: Tue, 12 Jul 2011 20:01:20 +0200 [thread overview]
Message-ID: <20110712180120.GU23227@redhat.com> (raw)
In-Reply-To: <CAPQyPG5asX4t_hhzmCeXLRnerXxuD2v8CRfQ2_RZqUcqdToskQ@mail.gmail.com>
On Wed, Jul 13, 2011 at 01:48:10AM +0800, Nai Xia wrote:
> I think in this case we should copy the page instead of going to unlock.
>
> And I think reuse_swap_page() has checked the PageKsm(page) inside and
> in this case it will go to the copy path already?
yes this is why it's unnecessary, I've been a bit in a paranoid mode
on this code lately, one more check wouldn't have hurted but it's
definitely unnecessary so please ignore...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-12 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 16:50 mm: do_wp_page recheck PageKsm after obtaining the page_lock, pte_same not enough Andrea Arcangeli
2011-07-12 17:48 ` Nai Xia
2011-07-12 18:01 ` Andrea Arcangeli [this message]
2011-07-12 17:53 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712180120.GU23227@redhat.com \
--to=aarcange@redhat.com \
--cc=hughd@google.com \
--cc=jweiner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
--cc=nai.xia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).