From: Mel Gorman <mgorman@suse.de>
To: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: vmscan: Do use use PF_SWAPWRITE from zone_reclaim
Date: Wed, 13 Jul 2011 11:40:25 +0100 [thread overview]
Message-ID: <20110713104025.GE7529@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1107121042240.2530@router.home>
On Tue, Jul 12, 2011 at 10:43:47AM -0500, Christoph Lameter wrote:
> On Tue, 12 Jul 2011, Minchan Kim wrote:
>
> > If I am not against this patch, at least, we need agreement of
> > Christoph and others and if we agree this change, we changes vm.txt,
> > too.
>
> I think PF_SWAPWRITE should only be set if may_write was set earlier in
> __zone_reclaim. If zone reclaim is not configured to do writeback then it
> makes no sense to set the bit.
>
That would effectively make the patch a no-op as the check for
PF_SWAPWRITE only happens if may_write is set. The point of the patch is
that zone reclaim differs from direct reclaim in that zone reclaim
obeys congestion where as zone reclaim does not. If you're saying that
this is the way it's meant to be, then fine, I'll drop the patch. While
I think it's a bad idea, I also didn't specifically test for problems
related to it and I think the other two patches in the series are more
important.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-13 10:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 13:01 [RFC PATCH 0/3] Reduce frequency of stalls due to zone_reclaim() on NUMA Mel Gorman
2011-07-11 13:01 ` [PATCH 1/3] mm: vmscan: Do use use PF_SWAPWRITE from zone_reclaim Mel Gorman
2011-07-12 9:27 ` Minchan Kim
2011-07-12 9:40 ` KOSAKI Motohiro
2011-07-12 9:55 ` Minchan Kim
2011-07-12 15:43 ` Christoph Lameter
2011-07-13 10:40 ` Mel Gorman [this message]
2011-07-12 10:14 ` Mel Gorman
2011-07-13 0:34 ` KOSAKI Motohiro
2011-07-11 13:01 ` [PATCH 2/3] mm: page allocator: Initialise ZLC for first zone eligible for zone_reclaim Mel Gorman
2011-07-13 1:15 ` KOSAKI Motohiro
2011-07-13 11:02 ` Mel Gorman
2011-07-14 1:20 ` KOSAKI Motohiro
2011-07-14 6:11 ` Mel Gorman
2011-07-11 13:01 ` [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim Mel Gorman
2011-07-13 0:42 ` KOSAKI Motohiro
2011-07-13 11:10 ` Mel Gorman
2011-07-14 3:20 ` KOSAKI Motohiro
2011-07-14 6:10 ` Mel Gorman
2011-07-21 9:35 ` KOSAKI Motohiro
2011-07-21 10:31 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713104025.GE7529@suse.de \
--to=mgorman@suse.de \
--cc=cl@linux.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).