From: Mel Gorman <mgorman@suse.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim
Date: Wed, 13 Jul 2011 12:10:17 +0100 [thread overview]
Message-ID: <20110713111017.GG7529@suse.de> (raw)
In-Reply-To: <4E1CE9FF.3050707@jp.fujitsu.com>
On Wed, Jul 13, 2011 at 09:42:39AM +0900, KOSAKI Motohiro wrote:
> (2011/07/11 22:01), Mel Gorman wrote:
> > With zone_reclaim_mode enabled, it's possible for zones to be considered
> > full in the zonelist_cache so they are skipped in the future. If the
> > process enters direct reclaim, the ZLC may still consider zones to be
> > full even after reclaiming pages. Reconsider all zones for allocation
> > if direct reclaim returns successfully.
> >
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
>
> Hmmm...
>
> I like the concept, but I'm worry about a corner case a bit.
>
> If users are using cpusets/mempolicy, direct reclaim don't scan all zones.
> Then, zlc_clear_zones_full() seems too aggressive operation.
As the system is likely to be running slow if it is in direct reclaim
that the complexity of being careful about which zone was cleared was
not worth it.
> Instead, couldn't we turn zlc->fullzones off from kswapd?
>
Which zonelist should it clear (there are two) and when should it
happen? If it clears it on each cycle around balance_pgdat(), there
is no guarantee that it'll be cleared between when direct reclaim
finishes and an attempt is made to allocate.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-13 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 13:01 [RFC PATCH 0/3] Reduce frequency of stalls due to zone_reclaim() on NUMA Mel Gorman
2011-07-11 13:01 ` [PATCH 1/3] mm: vmscan: Do use use PF_SWAPWRITE from zone_reclaim Mel Gorman
2011-07-12 9:27 ` Minchan Kim
2011-07-12 9:40 ` KOSAKI Motohiro
2011-07-12 9:55 ` Minchan Kim
2011-07-12 15:43 ` Christoph Lameter
2011-07-13 10:40 ` Mel Gorman
2011-07-12 10:14 ` Mel Gorman
2011-07-13 0:34 ` KOSAKI Motohiro
2011-07-11 13:01 ` [PATCH 2/3] mm: page allocator: Initialise ZLC for first zone eligible for zone_reclaim Mel Gorman
2011-07-13 1:15 ` KOSAKI Motohiro
2011-07-13 11:02 ` Mel Gorman
2011-07-14 1:20 ` KOSAKI Motohiro
2011-07-14 6:11 ` Mel Gorman
2011-07-11 13:01 ` [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim Mel Gorman
2011-07-13 0:42 ` KOSAKI Motohiro
2011-07-13 11:10 ` Mel Gorman [this message]
2011-07-14 3:20 ` KOSAKI Motohiro
2011-07-14 6:10 ` Mel Gorman
2011-07-21 9:35 ` KOSAKI Motohiro
2011-07-21 10:31 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2011-07-15 14:59 [PATCH 0/2] Reduce frequency of stalls due to zone_reclaim() on NUMA v2 Mel Gorman
2011-07-15 14:59 ` [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110713111017.GG7529@suse.de \
--to=mgorman@suse.de \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).