linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Christopher Yeoh <cyeoh@au1.ibm.com>
Cc: linux-mm@kvack.org
Subject: Re: [RESEND] Cross Memory Attach v3
Date: Fri, 15 Jul 2011 15:37:43 -0700	[thread overview]
Message-ID: <20110715153743.a0b3efc7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110708180607.3f11d324@lilo>

On Fri, 8 Jul 2011 18:06:07 +0930
Christopher Yeoh <cyeoh@au1.ibm.com> wrote:

> +static ssize_t process_vm_rw(pid_t pid, const struct iovec *lvec,
> +			     unsigned long liovcnt,
> +			     const struct iovec *rvec,
> +			     unsigned long riovcnt,
> +			     unsigned long flags, int vm_write)
> +{
>
> ...
>
> +	if (!mm || (task->flags & PF_KTHREAD)) {

Can a PF_KTHREAD thread have a non-zero ->mm?
> +		task_unlock(task);
> +		rc = -EINVAL;
> +		goto put_task_struct;
> +	}

anyway, grumble.

Please resend, cc'ing linux-kernel.

Please also cc linux-man@vger.kernel.org and describe (within the
changelog context) the plan for getting the manpages written.

Please also cc linux-arch@vger.kernel.org and provide (within the
changelog context) arch developers with the documentation and test code
which will enable them to implement this and to verify it with minimal
effort.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-15 22:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  8:36 [RESEND] Cross Memory Attach v3 Christopher Yeoh
2011-07-15 22:37 ` Andrew Morton [this message]
2011-07-18 15:05   ` Christopher Yeoh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110715153743.a0b3efc7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cyeoh@au1.ibm.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).