From: Randy Dunlap <rdunlap@xenotime.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org
Subject: Re: [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS
Date: Mon, 18 Jul 2011 10:14:35 -0700 [thread overview]
Message-ID: <20110718101435.14c38ae7.rdunlap@xenotime.net> (raw)
In-Reply-To: <20110718170950.GD8006@one.firstfloor.org>
On Mon, 18 Jul 2011 19:09:50 +0200 Andi Kleen wrote:
> On Mon, Jul 18, 2011 at 03:14:18PM +0300, Pekka Enberg wrote:
> > On Mon, Jul 18, 2011 at 2:18 PM, Amerigo Wang <amwang@redhat.com> wrote:
> > > On ppc, we got this build error with randconfig:
> > >
> > > drivers/built-in.o:(.toc1+0xf90): undefined reference to `vmstat_text': 1 errors in 1 logs
> > >
> > > This is due to that it enabled CONFIG_NUMA but not CONFIG_SYSFS.
> > >
> > > And the user-space tool numactl depends on sysfs files too.
> > > So, I think it is very reasonable to make CONFIG_NUMA depend on CONFIG_SYSFS.
> >
> > Is it? CONFIG_NUMA is useful even without userspace numactl tool, no?
>
> Yes it is. No direct dependency.
>
> I would rather fix it in ppc.
This isn't a ppc-only error. It happens when CONFIG_PROC_FS is not enabled
(or is it CONFIG_SYSFS?).
I reported it for linux-next of 20110526:
when CONFIG_PROC_FS is not enabled:
drivers/built-in.o: In function `node_read_vmstat':
node.c:(.text+0x56ffa): undefined reference to `vmstat_text'
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-18 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 11:18 [Patch] mm: make CONFIG_NUMA depend on CONFIG_SYSFS Amerigo Wang
2011-07-18 12:14 ` Pekka Enberg
2011-07-18 17:09 ` Andi Kleen
2011-07-18 17:14 ` Randy Dunlap [this message]
2011-07-19 6:07 ` Cong Wang
2011-07-18 13:52 ` Mel Gorman
2011-07-19 6:20 ` Cong Wang
2011-07-19 6:54 ` Eric Dumazet
2011-07-19 7:05 ` Cong Wang
2011-07-19 8:49 ` Eric Dumazet
2011-07-19 9:11 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718101435.14c38ae7.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).