From: Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-mm@kvack.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
viro@zeniv.linux.org.uk
Subject: Re: linux-next: Tree for July 18 (mm/truncate.c)
Date: Mon, 18 Jul 2011 11:21:18 -0400 [thread overview]
Message-ID: <20110718152117.GA8844@infradead.org> (raw)
In-Reply-To: <20110718081816.2106117e.rdunlap@xenotime.net>
On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote:
> On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'
>
> mm/truncate.c should be #include-ing <linux/fs.h> for that function's
> prototype, but that doesn't help when CONFIG_BLOCK is not enabled,
> which is the case in this build failure.
Oops. Two choices here:
a) stub it out for non-blocks.
b) move it out of directio.c so that it's always provided.
I'd be fine with either one. Al, any preferences?
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
---end quoted text---
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-18 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110718203501.232bd176e83ff65f056366e6@canb.auug.org.au>
2011-07-18 15:18 ` linux-next: Tree for July 18 (mm/truncate.c) Randy Dunlap
2011-07-18 15:21 ` Christoph Hellwig [this message]
2011-07-21 20:50 ` Al Viro
2011-07-21 20:55 ` [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled Randy Dunlap
2011-07-22 15:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718152117.GA8844@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).