From: Mel Gorman <mgorman@suse.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim
Date: Thu, 21 Jul 2011 11:31:49 +0100 [thread overview]
Message-ID: <20110721103149.GR5349@suse.de> (raw)
In-Reply-To: <4E27F2EC.2010902@jp.fujitsu.com>
On Thu, Jul 21, 2011 at 06:35:40PM +0900, KOSAKI Motohiro wrote:
> Hi
>
>
>
>
>
> >> So, I think we don't need to care zonelist, just kswapd turn off
> >> their own node.
> >
> > I don't understand what you mean by this.
>
> This was the answer of following your comments.
>
> > Instead, couldn't we turn zlc->fullzones off from kswapd?
> > >
> > > Which zonelist should it clear (there are two)
>
> I mean, buddy list is belong to zone, not zonelist. therefore, kswapd
> don't need to look up zonelist.
>
> So, I'd suggest either following way,
> - use direct reclaim path, but only clear a zlc bit of zones in reclaimed zonelist, not all. or
We certainly could narrow the number of zones the bits are
cleared on by exporting knowledge of the ZLC to vmscan for use in
shrink_zones(). I think in practice the end result will be the same
though as shrink_zones() examples all zones in the zonelist. How much
of a gain do you expect the additional complexity to give us?
> - use kswapd and only clear a zlc bit at kswap exiting balance_pgdat
>
That is potentially a long time if there are streaming readers keeping a
zone under the high watermark for a long time.
> I'm prefer to add a branch to slowpath (ie reclaim path) rather than fast path.
>
The clearing of the zonelist is already happening after direct reclaim
which is the slow path. What fast path are you concerned with here?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-21 10:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 13:01 [RFC PATCH 0/3] Reduce frequency of stalls due to zone_reclaim() on NUMA Mel Gorman
2011-07-11 13:01 ` [PATCH 1/3] mm: vmscan: Do use use PF_SWAPWRITE from zone_reclaim Mel Gorman
2011-07-12 9:27 ` Minchan Kim
2011-07-12 9:40 ` KOSAKI Motohiro
2011-07-12 9:55 ` Minchan Kim
2011-07-12 15:43 ` Christoph Lameter
2011-07-13 10:40 ` Mel Gorman
2011-07-12 10:14 ` Mel Gorman
2011-07-13 0:34 ` KOSAKI Motohiro
2011-07-11 13:01 ` [PATCH 2/3] mm: page allocator: Initialise ZLC for first zone eligible for zone_reclaim Mel Gorman
2011-07-13 1:15 ` KOSAKI Motohiro
2011-07-13 11:02 ` Mel Gorman
2011-07-14 1:20 ` KOSAKI Motohiro
2011-07-14 6:11 ` Mel Gorman
2011-07-11 13:01 ` [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim Mel Gorman
2011-07-13 0:42 ` KOSAKI Motohiro
2011-07-13 11:10 ` Mel Gorman
2011-07-14 3:20 ` KOSAKI Motohiro
2011-07-14 6:10 ` Mel Gorman
2011-07-21 9:35 ` KOSAKI Motohiro
2011-07-21 10:31 ` Mel Gorman [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-15 14:59 [PATCH 0/2] Reduce frequency of stalls due to zone_reclaim() on NUMA v2 Mel Gorman
2011-07-15 14:59 ` [PATCH 3/3] mm: page allocator: Reconsider zones for allocation after direct reclaim Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721103149.GR5349@suse.de \
--to=mgorman@suse.de \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).