Re: [RFC v3 2/5] slab: implement slab object boundaries assertion

[Vasiliy Kulikov <segoon@openwall.com>]

On Thu, Jul 21, 2011 at 11:28 -0500, Christoph Lameter wrote:
> On Thu, 21 Jul 2011, Vasiliy Kulikov wrote:
> 
> > +bool slab_access_ok(const void *ptr, unsigned long len)
> > +{
> > +	struct page *page;
> > +	struct kmem_cache *s = NULL;
> 
> Useless assignment.
> 
> > +	unsigned long offset;
> > +
> > +	if (!virt_addr_valid(ptr))
> > +		return true;
> > +	page = virt_to_head_page(ptr);
> > +	if (!PageSlab(page))
> > +		return true;
> > +
> > +	s = page->slab;
> > +	offset = (ptr - page_address(page)) % s->size;
> > +	if (offset <= s->objsize && len <= s->objsize - offset)
> > +		return true;
> 
> I thought this was going to be offset < s->objectsize ...?

Looks like I did these 2 things in SLAB only, left SLUB untouched.
Will fix, thanks.

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>