Re: linux-next: Tree for July 18 (mm/truncate.c)

Re: linux-next: Tree for July 18 (mm/truncate.c)

[Randy Dunlap]

On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote:

> Hi all,

mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'

mm/truncate.c should be #include-ing <linux/fs.h> for that function's
prototype, but that doesn't help when CONFIG_BLOCK is not enabled,
which is the case in this build failure.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: linux-next: Tree for July 18 (mm/truncate.c)

[Christoph Hellwig]

On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote:
> On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'
> 
> mm/truncate.c should be #include-ing <linux/fs.h> for that function's
> prototype, but that doesn't help when CONFIG_BLOCK is not enabled,
> which is the case in this build failure.

Oops.  Two choices here:

 a) stub it out for non-blocks.
 b) move it out of directio.c so that it's always provided.

I'd be fine with either one.  Al, any preferences?

> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
---end quoted text---

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: linux-next: Tree for July 18 (mm/truncate.c)

[Al Viro]

On Mon, Jul 18, 2011 at 11:21:18AM -0400, Christoph Hellwig wrote:
> On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote:
> > On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote:
> > 
> > > Hi all,
> > 
> > mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'
> > 
> > mm/truncate.c should be #include-ing <linux/fs.h> for that function's
> > prototype, but that doesn't help when CONFIG_BLOCK is not enabled,
> > which is the case in this build failure.
> 
> Oops.  Two choices here:
> 
>  a) stub it out for non-blocks.
>  b) move it out of directio.c so that it's always provided.
> 
> I'd be fine with either one.  Al, any preferences?

None...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix build error when CONFIG_BLOCK is not enabled by providing a stub
inode_dio_wait() function.

mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 include/linux/fs.h |    4 ++++
 1 file changed, 4 insertions(+)

--- linux-next-20110721.orig/include/linux/fs.h
+++ linux-next-20110721/include/linux/fs.h
@@ -2418,6 +2418,10 @@ static inline ssize_t blockdev_direct_IO
 				    offset, nr_segs, get_block, NULL, NULL,
 				    DIO_LOCKING | DIO_SKIP_HOLES);
 }
+#else
+static inline void inode_dio_wait(struct inode *inode)
+{
+}
 #endif
 
 extern const struct file_operations generic_ro_fops;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled

[Christoph Hellwig]

On Thu, Jul 21, 2011 at 01:55:37PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix build error when CONFIG_BLOCK is not enabled by providing a stub
> inode_dio_wait() function.
> 
> mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>

Looks good to me, thanks a lot Randy!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>