* Re: linux-next: Tree for July 18 (mm/truncate.c) [not found] <20110718203501.232bd176e83ff65f056366e6@canb.auug.org.au> @ 2011-07-18 15:18 ` Randy Dunlap 2011-07-18 15:21 ` Christoph Hellwig 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2011-07-18 15:18 UTC (permalink / raw) To: Stephen Rothwell, linux-mm; +Cc: linux-next, LKML, akpm On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote: > Hi all, mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' mm/truncate.c should be #include-ing <linux/fs.h> for that function's prototype, but that doesn't help when CONFIG_BLOCK is not enabled, which is the case in this build failure. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for July 18 (mm/truncate.c) 2011-07-18 15:18 ` linux-next: Tree for July 18 (mm/truncate.c) Randy Dunlap @ 2011-07-18 15:21 ` Christoph Hellwig 2011-07-21 20:50 ` Al Viro 2011-07-21 20:55 ` [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled Randy Dunlap 0 siblings, 2 replies; 5+ messages in thread From: Christoph Hellwig @ 2011-07-18 15:21 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-mm, linux-next, LKML, akpm, viro On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote: > On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote: > > > Hi all, > > mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' > > mm/truncate.c should be #include-ing <linux/fs.h> for that function's > prototype, but that doesn't help when CONFIG_BLOCK is not enabled, > which is the case in this build failure. Oops. Two choices here: a) stub it out for non-blocks. b) move it out of directio.c so that it's always provided. I'd be fine with either one. Al, any preferences? > > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ---end quoted text--- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for July 18 (mm/truncate.c) 2011-07-18 15:21 ` Christoph Hellwig @ 2011-07-21 20:50 ` Al Viro 2011-07-21 20:55 ` [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled Randy Dunlap 1 sibling, 0 replies; 5+ messages in thread From: Al Viro @ 2011-07-21 20:50 UTC (permalink / raw) To: Christoph Hellwig Cc: Randy Dunlap, Stephen Rothwell, linux-mm, linux-next, LKML, akpm On Mon, Jul 18, 2011 at 11:21:18AM -0400, Christoph Hellwig wrote: > On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote: > > On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote: > > > > > Hi all, > > > > mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' > > > > mm/truncate.c should be #include-ing <linux/fs.h> for that function's > > prototype, but that doesn't help when CONFIG_BLOCK is not enabled, > > which is the case in this build failure. > > Oops. Two choices here: > > a) stub it out for non-blocks. > b) move it out of directio.c so that it's always provided. > > I'd be fine with either one. Al, any preferences? None... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled 2011-07-18 15:21 ` Christoph Hellwig 2011-07-21 20:50 ` Al Viro @ 2011-07-21 20:55 ` Randy Dunlap 2011-07-22 15:06 ` Christoph Hellwig 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2011-07-21 20:55 UTC (permalink / raw) To: Christoph Hellwig, viro Cc: Stephen Rothwell, linux-mm, linux-next, LKML, akpm From: Randy Dunlap <rdunlap@xenotime.net> Fix build error when CONFIG_BLOCK is not enabled by providing a stub inode_dio_wait() function. mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> --- include/linux/fs.h | 4 ++++ 1 file changed, 4 insertions(+) --- linux-next-20110721.orig/include/linux/fs.h +++ linux-next-20110721/include/linux/fs.h @@ -2418,6 +2418,10 @@ static inline ssize_t blockdev_direct_IO offset, nr_segs, get_block, NULL, NULL, DIO_LOCKING | DIO_SKIP_HOLES); } +#else +static inline void inode_dio_wait(struct inode *inode) +{ +} #endif extern const struct file_operations generic_ro_fops; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled 2011-07-21 20:55 ` [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled Randy Dunlap @ 2011-07-22 15:06 ` Christoph Hellwig 0 siblings, 0 replies; 5+ messages in thread From: Christoph Hellwig @ 2011-07-22 15:06 UTC (permalink / raw) To: Randy Dunlap Cc: Christoph Hellwig, viro, Stephen Rothwell, linux-mm, linux-next, LKML, akpm On Thu, Jul 21, 2011 at 01:55:37PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@xenotime.net> > > Fix build error when CONFIG_BLOCK is not enabled by providing a stub > inode_dio_wait() function. > > mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait' > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Looks good to me, thanks a lot Randy! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-22 15:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110718203501.232bd176e83ff65f056366e6@canb.auug.org.au>
2011-07-18 15:18 ` linux-next: Tree for July 18 (mm/truncate.c) Randy Dunlap
2011-07-18 15:21 ` Christoph Hellwig
2011-07-21 20:50 ` Al Viro
2011-07-21 20:55 ` [PATCH -next] mm/truncate.c: fix build for CONFIG_BLOCK not enabled Randy Dunlap
2011-07-22 15:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).