From: Christoph Hellwig <hch@infradead.org>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
fuse-devel@lists.sourceforge.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] fuse: delete dead .write_begin and .write_end aops
Date: Mon, 25 Jul 2011 16:49:42 -0400 [thread overview]
Message-ID: <20110725204942.GA12183@infradead.org> (raw)
In-Reply-To: <1311626135-14279-1-git-send-email-jweiner@redhat.com>
On Mon, Jul 25, 2011 at 10:35:34PM +0200, Johannes Weiner wrote:
> Ever since 'ea9b990 fuse: implement perform_write', the .write_begin
> and .write_end aops have been dead code.
>
> Their task - acquiring a page from the page cache, sending out a write
> request and releasing the page again - is now done batch-wise to
> maximize the number of pages send per userspace request.
The loop code still calls them uncondtionally. This actually is a big
as write_begin and write_end require filesystems specific locking,
and might require code in the filesystem to e.g. update the ctime
properly. I'll let Miklos chime in if leaving them in was intentional,
and if it was a comment is probably justified.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-25 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 20:35 [patch 1/2] fuse: delete dead .write_begin and .write_end aops Johannes Weiner
2011-07-25 20:35 ` [patch 2/2] fuse: mark pages accessed when written to Johannes Weiner
2011-08-08 15:06 ` Miklos Szeredi
2011-07-25 20:49 ` Christoph Hellwig [this message]
2011-08-08 15:05 ` [patch 1/2] fuse: delete dead .write_begin and .write_end aops Miklos Szeredi
2011-08-10 10:26 ` Christoph Hellwig
2011-08-10 11:24 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725204942.GA12183@infradead.org \
--to=hch@infradead.org \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).