From: Mel Gorman <mgorman@suse.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [patch 3/3]vmscan: cleanup kswapd_try_to_sleep
Date: Thu, 28 Jul 2011 12:03:05 +0100 [thread overview]
Message-ID: <20110728110304.GL3010@suse.de> (raw)
In-Reply-To: <1311840789.15392.409.camel@sli10-conroe>
On Thu, Jul 28, 2011 at 04:13:09PM +0800, Shaohua Li wrote:
> cleanup kswapd_try_to_sleep() a little bit. Sometimes kswapd doesn't
> really sleep. In such case, don't call prepare_to_wait/finish_wait.
> It just wastes CPU.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Out of curiousity, under what circumstances is the CPU usage
noticeable? The patch itself seems fine so;
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-28 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 8:13 [patch 3/3]vmscan: cleanup kswapd_try_to_sleep Shaohua Li
2011-07-28 11:03 ` Mel Gorman [this message]
2011-07-29 0:17 ` Shaohua Li
2011-07-29 9:39 ` Minchan Kim
2011-07-29 10:46 ` Shaohua Li
2011-08-02 0:35 ` KOSAKI Motohiro
2011-08-02 1:03 ` Shaohua Li
2011-08-02 1:48 ` KOSAKI Motohiro
2011-08-19 23:56 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728110304.GL3010@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).