From: Dave Chinner <david@fromorbit.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jaxboe@fusionio.com>,
Shaohua Li <shaohua.li@intel.com>,
"mgorman@suse.de" <mgorman@suse.de>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]vmscan: add block plug for page reclaim
Date: Fri, 29 Jul 2011 20:43:05 +1000 [thread overview]
Message-ID: <20110729104305.GI5404@dastard> (raw)
In-Reply-To: <20110729083847.GB1843@barrios-desktop>
On Fri, Jul 29, 2011 at 05:38:47PM +0900, Minchan Kim wrote:
> On Wed, Jul 27, 2011 at 04:45:23PM -0700, Andrew Morton wrote:
> > Using an additional 44 bytes of stack on that path is also
> > significant(ly bad). But we need to fix that problem anyway. One way
> > we could improve things in mm/vmscan.c is to move the blk_plug into
> > scan_control then get the scan_control off the stack in some manner.
> > That's easy for kswapd: allocate one scan_control per kswapd at
> > startup. Doing it for direct-reclaim would be a bit trickier...
>
> Stack diet in direct reclaim...
> Of course, it's a matter as I pointed out in this patch
> but frankly speaking, it's very annoying to consider stack usage
> whenever we add something in direct reclaim path.
It's a fact of life that direct reclaim has to live with - memory
allocation can occur with a lot of stack already consumed. If you
don't want to care about stack usage, then lets increase the default
stack size to 16k for x86-64.....
> I think better solution is to avoid write in direct reclaim like the approach of Mel.
Yeah, and we should probably stop swapping in the direct reclaim
path, too, because I've seen the stack usage from memory allocation
to swap IO issue exceed 4k on x86-64....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-07-29 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 2:53 [PATCH]vmscan: add block plug for page reclaim Shaohua Li
2011-07-20 5:53 ` Minchan Kim
2011-07-20 6:10 ` Shaohua Li
2011-07-20 6:30 ` Minchan Kim
2011-07-20 6:49 ` Shaohua Li
2011-07-21 19:32 ` Jens Axboe
2011-07-22 5:14 ` Shaohua Li
2011-07-23 18:49 ` Jens Axboe
2011-07-27 3:09 ` Shaohua Li
2011-07-27 23:45 ` Andrew Morton
2011-07-28 1:04 ` Shaohua Li
2011-07-28 1:15 ` Andrew Morton
2011-07-28 1:34 ` Shaohua Li
2011-07-29 8:38 ` Minchan Kim
2011-07-29 10:30 ` Shaohua Li
2011-07-29 10:43 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729104305.GI5404@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).