From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ying Han <yinghan@google.com>,
Balbir Singh <bsingharora@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch 1/2] mm: vmscan: fix force-scanning small targets without swap
Date: Fri, 12 Aug 2011 15:13:14 +0200 [thread overview]
Message-ID: <20110812131314.GC32335@tiehlicka.suse.cz> (raw)
In-Reply-To: <20110812131042.GB32335@tiehlicka.suse.cz>
On Fri 12-08-11 15:10:42, Michal Hocko wrote:
> On Thu 11-08-11 22:31:54, Johannes Weiner wrote:
> > Without swap, anonymous pages are not scanned. As such, they should
> > not count when considering force-scanning a small target if there is
> > no swap.
> >
> > Otherwise, targets are not force-scanned even when their effective
> > scan number is zero and the other conditions--kswapd/memcg--apply.
> >
> > Signed-off-by: Johannes Weiner <jweiner@redhat.com>
>
> We are calculating nr_force_scan even if it is not needed but this
> shouldn't hurt.
Ahh and the second patch removes that calculation. Sorry for noise.
> Reviewed-by: Michal Hocko <mhocko@suse.cz>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-12 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 20:31 [patch 1/2] mm: vmscan: fix force-scanning small targets without swap Johannes Weiner
2011-08-11 20:31 ` [patch 2/2] mm: vmscan: drop nr_force_scan[] from get_scan_count Johannes Weiner
2011-08-11 23:44 ` Minchan Kim
2011-08-12 6:58 ` Johannes Weiner
2011-08-12 7:04 ` Minchan Kim
2011-08-12 13:33 ` Michal Hocko
2011-08-17 14:00 ` Mel Gorman
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-11 23:16 ` [patch 1/2] mm: vmscan: fix force-scanning small targets without swap Minchan Kim
2011-08-12 13:10 ` Michal Hocko
2011-08-12 13:13 ` Michal Hocko [this message]
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-17 13:38 ` Mel Gorman
2011-08-29 16:08 ` Johannes Weiner
2011-08-31 23:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812131314.GC32335@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).