From: Minchan Kim <minchan.kim@gmail.com>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/3] compaction: compact unevictable page
Date: Wed, 31 Aug 2011 23:41:50 +0900 [thread overview]
Message-ID: <20110831144150.GA1860@barrios-desktop> (raw)
In-Reply-To: <20110831111954.GB17512@redhat.com>
On Wed, Aug 31, 2011 at 01:19:54PM +0200, Johannes Weiner wrote:
> On Sun, Nov 13, 2011 at 01:37:42AM +0900, Minchan Kim wrote:
> > Now compaction doesn't handle mlocked page as it uses __isolate_lru_page
> > which doesn't consider unevicatable page. It has been used by just lumpy so
> > it was pointless that it isolates unevictable page. But the situation is
> > changed. Compaction could handle unevictable page and it can help getting
> > big contiguos pages in fragment memory by many pinned page with mlock.
>
> This may result in applications unexpectedly faulting and waiting on
> mlocked pages under migration. I wonder how realtime people feel
> about that?
I didn't consider it but it's very important point.
The migrate_page can call pageout on dirty page so RT process could wait on the
mlocked page during very long time.
I can mitigate it with isolating mlocked page in case of !sync but still we can't
guarantee the time because we can't know how many vmas point the page so that try_to_unmap
could spend lots of time.
We can think it's a trade off between high order allocation VS RT latency.
Now I am biasing toward RT latency as considering mlock man page.
Any thoughts?
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-31 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 16:37 [PATCH 0/3] Fix compaction about mlocked pages Minchan Kim
2011-08-29 16:43 ` [PATCH 3/3] compaction accouting fix Minchan Kim
2011-08-29 16:43 ` [PATCH 1/3] Correct isolate_mode_t bitwise type Minchan Kim
2011-08-29 16:43 ` [PATCH 2/3] compaction: compact unevictable page Minchan Kim
2011-10-06 21:54 ` [PATCH 0/3] Fix compaction about mlocked pages Andrew Morton
2011-10-06 23:07 ` Minchan Kim
2011-11-12 16:37 ` [PATCH 1/3] Correct isolate_mode_t bitwise type Minchan Kim
2011-08-30 17:51 ` Rik van Riel
2011-08-31 11:13 ` Johannes Weiner
2011-09-01 13:05 ` Mel Gorman
2011-09-02 3:29 ` Minchan Kim
2011-11-12 16:37 ` [PATCH 2/3] compaction: compact unevictable page Minchan Kim
2011-08-31 1:09 ` Rik van Riel
2011-08-31 11:19 ` Johannes Weiner
2011-08-31 14:41 ` Minchan Kim [this message]
2011-09-01 14:02 ` Mel Gorman
2011-09-02 4:48 ` Minchan Kim
2011-09-02 13:34 ` Mel Gorman
2011-11-12 16:37 ` [PATCH 3/3] compaction accouting fix Minchan Kim
2011-08-31 11:37 ` Johannes Weiner
2011-08-31 14:56 ` Minchan Kim
2011-08-31 15:03 ` Johannes Weiner
2011-09-01 14:20 ` Mel Gorman
2011-09-02 5:09 ` Minchan Kim
2011-09-02 13:36 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831144150.GA1860@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).