From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id C12909000C6 for ; Tue, 20 Sep 2011 14:40:59 -0400 (EDT) Date: Tue, 20 Sep 2011 14:40:34 -0400 From: Christoph Hellwig Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Message-ID: <20110920184034.GA27353@infradead.org> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> <4E78DD8B.1020605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E78DD8B.1020605@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Christoph Hellwig , Johannes Weiner , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , Theodore Ts'o , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > >In addition to regular write shouldn't __do_fault and do_wp_page also > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always creates an > anonymous page, which are not very relevant to the > dirty page cache accounting. Well, it doesn't always - but for the case where it doesn't we do not allocate a new page at all so you're right in the end :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org