From: Michal Hocko <mhocko@suse.cz>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: [patch]mm: initialize zone all_unreclaimable
Date: Mon, 26 Sep 2011 15:23:20 +0200 [thread overview]
Message-ID: <20110926132320.GA4206@tiehlicka.suse.cz> (raw)
In-Reply-To: <1317024712.29510.178.camel@sli10-conroe>
On Mon 26-09-11 16:11:52, Shaohua Li wrote:
> I saw DMA zone is always unreclaimable in my system.
> zone->all_unreclaimable isn't initialized till a page from the zone is
> freed. This isn't a big problem normally, but a little confused, so
> fix here.
The value is initialized when a node is allocated. setup_node_data uses
alloc_remap which memsets the whole structure or memblock allocation
which is initialized to 0 as well AFAIK and memory hotplug uses
arch_alloc_nodedata which is kzalloc.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6e8ecb6..1facc05 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4335,6 +4335,7 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat,
> zone_pcp_init(zone);
> for_each_lru(l)
> INIT_LIST_HEAD(&zone->lru[l].list);
> + zone->all_unreclaimable = 0;
> zone->reclaim_stat.recent_rotated[0] = 0;
> zone->reclaim_stat.recent_rotated[1] = 0;
> zone->reclaim_stat.recent_scanned[0] = 0;
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-26 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 8:11 [patch]mm: initialize zone all_unreclaimable Shaohua Li
2011-09-26 13:23 ` Michal Hocko [this message]
2011-09-26 22:52 ` Andrew Morton
2011-09-27 1:10 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926132320.GA4206@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).