linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: David Rientjes <rientjes@google.com>
Cc: kernel-hardening@lists.openwall.com,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Kees Cook <kees@ubuntu.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Valdis.Kletnieks@vt.edu,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: restrict access to /proc/meminfo
Date: Tue, 27 Sep 2011 23:14:13 +0400	[thread overview]
Message-ID: <20110927191413.GA4820@albatros> (raw)
In-Reply-To: <alpine.DEB.2.00.1109271122480.17876@chino.kir.corp.google.com>

On Tue, Sep 27, 2011 at 11:27 -0700, David Rientjes wrote:
> On Tue, 27 Sep 2011, Vasiliy Kulikov wrote:
> 
> > /proc/meminfo stores information related to memory pages usage, which
> > may be used to monitor the number of objects in specific caches (and/or
> > the changes of these numbers).  This might reveal private information
> > similar to /proc/slabinfo infoleaks.  To remove the infoleak, just
> > restrict meminfo to root.  If it is used by unprivileged daemons,
> > meminfo permissions can be altered the same way as slabinfo:
> > 
> >     groupadd meminfo
> >     usermod -a -G meminfo $MONITOR_USER
> >     chmod g+r /proc/meminfo
> >     chgrp meminfo /proc/meminfo
> > 
> 
> I guess the side-effect of this is that users without root will no longer 
> report VM issues where "there's tons of freeable memory but my task got 
> killed", "there's swap available but is unutilized in lowmem situations", 
> etc. :)

Uhh, lost of "free" is rather significant.

> Seriously, though, can't we just change the granularity of /proc/meminfo 
> to be MB instead of KB or at least provide a separate file that is 
> readable that does that?  I can understand not exporting information on a 
> page-level granularity but not giving users a way to determine the amount 
> of free memory is a little extreme.

Probably it is the way to go.  Users still may identify *some*
information about the slab objects in question (ecryptfs, etc.), but it
is more limited with MB granularity.  Though, it is probably the only
acceptable tradeoff in sense of backward compatibility.

Thank you,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-09-27 19:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 17:54 [PATCH 1/2] mm: restrict access to slab files under procfs and sysfs Vasiliy Kulikov
2011-09-27 17:56 ` [PATCH 2/2] mm: restrict access to /proc/meminfo Vasiliy Kulikov
2011-09-27 18:27   ` David Rientjes
2011-09-27 19:14     ` Vasiliy Kulikov [this message]
2011-09-27 19:38   ` Vasiliy Kulikov
2011-09-27 20:03     ` Christoph Lameter
2011-09-27 20:33       ` David Rientjes
2011-09-27 20:47         ` Christoph Lameter
2011-09-28 20:31           ` Dave Hansen
2011-09-28 20:52             ` Alan Cox
2011-09-29  0:43             ` Valdis.Kletnieks
2011-09-29 14:11               ` Christoph Lameter
2011-09-29 16:18         ` Vasiliy Kulikov
2011-09-29 16:30           ` Dave Hansen
2011-09-29 16:43             ` [kernel-hardening] " Vasiliy Kulikov
2011-09-29 16:57           ` Valdis.Kletnieks
2011-09-29 17:25             ` [kernel-hardening] " Vasiliy Kulikov
2011-09-29 17:28           ` Vasiliy Kulikov
2011-09-28 21:46     ` Andrew Morton
2011-09-30 19:53       ` Vasiliy Kulikov
2011-09-30 20:03         ` Andrew Morton
2011-09-30 20:12           ` Vasiliy Kulikov
2011-09-30 20:15           ` Dave Hansen
2011-09-27 18:08 ` [PATCH 1/2] mm: restrict access to slab files under procfs and sysfs Christoph Lameter
2011-09-27 19:16   ` Vasiliy Kulikov
2011-09-27 19:35     ` Christoph Lameter
2011-09-27 18:21 ` David Rientjes
2011-09-27 20:00   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110927191413.GA4820@albatros \
    --to=segoon@openwall.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=cl@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=kees@ubuntu.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).