* [PATCH] mm: compaction: staticize compact_zone_order
@ 2011-09-21 8:58 Kyungmin Park
2011-09-21 17:18 ` David Rientjes
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kyungmin Park @ 2011-09-21 8:58 UTC (permalink / raw)
To: Andrew Morton, Mel Gorman, Andrea Arcangeli, Johannes Weiner,
Minchan Kim
Cc: linux-kernel, linux-mm
From: Kyungmin Park <kyungmin.park@samsung.com>
There's no user to use compact_zone_order. So staticize this function.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/include/linux/compaction.h b/include/linux/compaction.h
index cc9f7a4..bb2bbdb 100644
--- a/include/linux/compaction.h
+++ b/include/linux/compaction.h
@@ -24,8 +24,6 @@ extern unsigned long try_to_compact_pages(struct zonelist *zonelist,
int order, gfp_t gfp_mask, nodemask_t *mask,
bool sync);
extern unsigned long compaction_suitable(struct zone *zone, int order);
-extern unsigned long compact_zone_order(struct zone *zone, int order,
- gfp_t gfp_mask, bool sync);
/* Do not skip compaction more than 64 times */
#define COMPACT_MAX_DEFER_SHIFT 6
@@ -69,12 +67,6 @@ static inline unsigned long compaction_suitable(struct zone *zone, int order)
return COMPACT_SKIPPED;
}
-static inline unsigned long compact_zone_order(struct zone *zone, int order,
- gfp_t gfp_mask, bool sync)
-{
- return COMPACT_CONTINUE;
-}
-
static inline void defer_compaction(struct zone *zone)
{
}
diff --git a/mm/compaction.c b/mm/compaction.c
index 6cc604b..c17079e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -586,7 +586,7 @@ out:
return ret;
}
-unsigned long compact_zone_order(struct zone *zone,
+static unsigned long compact_zone_order(struct zone *zone,
int order, gfp_t gfp_mask,
bool sync)
{
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: compaction: staticize compact_zone_order
2011-09-21 8:58 [PATCH] mm: compaction: staticize compact_zone_order Kyungmin Park
@ 2011-09-21 17:18 ` David Rientjes
2011-09-22 11:21 ` Mel Gorman
2011-09-28 6:04 ` Minchan Kim
2 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2011-09-21 17:18 UTC (permalink / raw)
To: Kyungmin Park
Cc: Andrew Morton, Mel Gorman, Andrea Arcangeli, Johannes Weiner,
Minchan Kim, linux-kernel, linux-mm
On Wed, 21 Sep 2011, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> There's no user to use compact_zone_order. So staticize this function.
>
s/no user/no user outside of file scope/
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: compaction: staticize compact_zone_order
2011-09-21 8:58 [PATCH] mm: compaction: staticize compact_zone_order Kyungmin Park
2011-09-21 17:18 ` David Rientjes
@ 2011-09-22 11:21 ` Mel Gorman
2011-09-28 6:04 ` Minchan Kim
2 siblings, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2011-09-22 11:21 UTC (permalink / raw)
To: Kyungmin Park
Cc: Andrew Morton, Andrea Arcangeli, Johannes Weiner, Minchan Kim,
linux-kernel, linux-mm
On Wed, Sep 21, 2011 at 05:58:43PM +0900, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> There's no user to use compact_zone_order. So staticize this function.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: compaction: staticize compact_zone_order
2011-09-21 8:58 [PATCH] mm: compaction: staticize compact_zone_order Kyungmin Park
2011-09-21 17:18 ` David Rientjes
2011-09-22 11:21 ` Mel Gorman
@ 2011-09-28 6:04 ` Minchan Kim
2 siblings, 0 replies; 4+ messages in thread
From: Minchan Kim @ 2011-09-28 6:04 UTC (permalink / raw)
To: Kyungmin Park
Cc: Andrew Morton, Mel Gorman, Andrea Arcangeli, Johannes Weiner,
linux-kernel, linux-mm
On Wed, Sep 21, 2011 at 05:58:43PM +0900, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> There's no user to use compact_zone_order. So staticize this function.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kinds regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-28 6:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-21 8:58 [PATCH] mm: compaction: staticize compact_zone_order Kyungmin Park
2011-09-21 17:18 ` David Rientjes
2011-09-22 11:21 ` Mel Gorman
2011-09-28 6:04 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).