From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 281E39000BD for ; Thu, 29 Sep 2011 21:51:55 -0400 (EDT) Received: by iaen33 with SMTP id n33so2118237iae.14 for ; Thu, 29 Sep 2011 18:51:53 -0700 (PDT) Date: Thu, 29 Sep 2011 18:51:48 -0700 From: Tejun Heo Subject: Re: [patch] oom: thaw threads if oom killed thread is frozen before deferring Message-ID: <20110930015148.GD10425@mtj.dyndns.org> References: <65d9dff7ff78fad1f146e71d32f9f92741281b46.1317110948.git.mhocko@suse.cz> <20110928104445.GB15062@tiehlicka.suse.cz> <20110929115105.GE21113@tiehlicka.suse.cz> <20110929120517.GA10587@redhat.com> <20110929130204.GG21113@tiehlicka.suse.cz> <20110929163724.GA23773@redhat.com> <20110929180021.GA27999@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110929180021.GA27999@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Oleg Nesterov , David Rientjes , Andrew Morton , Konstantin Khlebnikov , KOSAKI Motohiro , KAMEZAWA Hiroyuki , "Rafael J. Wysocki" , Rusty Russell , linux-kernel@vger.kernel.org, linux-mm@kvack.org Hello, On Thu, Sep 29, 2011 at 08:00:21PM +0200, Michal Hocko wrote: > > I meant, oom_kill can do this before thaw thaw_process(), afaics > > this should fix the particular race you described (but not others). > > This is what the follow up fix from David is doing. Check frozen in > select_bad_process if the task is TIF_MEMDIE and thaw the process. > > And it seems that the David's follow up fix is sufficient so let's leave > refrigerator alone. > Or am I still missing something? With pending freezer changes, allowing TIF_MEMDIE tasks to exit freezer by modifying freezing() shouldn't be difficult, which should be race-free and much simpler than diddling with thaw_task(). How urgent is this? Can we wait for the next merge window? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org