From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 3C73B6B002E for ; Mon, 24 Oct 2011 12:12:16 -0400 (EDT) Date: Mon, 24 Oct 2011 18:07:32 +0200 From: Oleg Nesterov Subject: Re: [PATCH 11/X] uprobes: x86: introduce xol_was_trapped() Message-ID: <20111024160732.GA19659@redhat.com> References: <20110920115938.25326.93059.sendpatchset@srdronam.in.ibm.com> <20111015190007.GA30243@redhat.com> <20111019215139.GA16395@redhat.com> <20111019215307.GE16395@redhat.com> <20111024145531.GB31435@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111024145531.GB31435@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Jonathan Corbet , Masami Hiramatsu , Hugh Dickins , Christoph Hellwig , Ananth N Mavinakayanahalli , Thomas Gleixner , Andi Kleen , Andrew Morton , Jim Keniston , Roland McGrath , LKML On 10/24, Srikar Dronamraju wrote: > > > diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm/uprobes.h > > index 1c30cfd..f0fbdab 100644 > > --- a/arch/x86/include/asm/uprobes.h > > +++ b/arch/x86/include/asm/uprobes.h > > @@ -39,6 +39,7 @@ struct uprobe_arch_info { > > > > struct uprobe_task_arch_info { > > unsigned long saved_scratch_register; > > + unsigned long saved_trap_no; > > }; > > #else > > struct uprobe_arch_info {}; > > > one nit > I had to add saved_trap_no to #else part (i.e uprobe_arch_info ). Yes, thanks, I didn't notice this is for X86_64 only. And just in case, please feel free to rename/redo/whatever. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org