From: Andrea Arcangeli <aarcange@redhat.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/5]thp: improve the error code path
Date: Tue, 25 Oct 2011 13:44:06 +0200 [thread overview]
Message-ID: <20111025114406.GC10182@redhat.com> (raw)
In-Reply-To: <1319511521.22361.135.camel@sli10-conroe>
Hello,
On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> +#ifdef CONFIG_SYSFS
> + sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> +remove_hp_group:
> + sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> +delete_obj:
> + kobject_put(hugepage_kobj);
> out:
> +#endif
Adding an ifdef is making the code worse, the whole point of having
these functions become noops at build time is to avoid having to add
ifdefs in the callers.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-25 11:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 2:58 [patch 1/5]thp: improve the error code path Shaohua Li
2011-10-25 11:44 ` Andrea Arcangeli [this message]
2011-10-26 1:48 ` Shaohua Li
2011-11-07 5:17 ` Shaohua Li
2011-11-10 2:18 ` Andrea Arcangeli
2011-11-10 2:33 ` Shaohua Li
2011-11-10 2:43 ` David Rientjes
2011-11-10 3:06 ` Andrea Arcangeli
2011-11-10 4:43 ` David Rientjes
2011-11-10 5:56 ` Shaohua Li
2011-11-10 6:08 ` David Rientjes
2011-11-10 6:27 ` Shaohua Li
2011-11-10 14:14 ` Andrea Arcangeli
2011-11-11 6:33 ` Shaohua Li
2011-11-11 6:50 ` Andrea Arcangeli
2011-11-10 2:59 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025114406.GC10182@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).