From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wu Fengguang <fengguang.wu@intel.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] vmscan: promote shared file mapped pages
Date: Mon, 31 Oct 2011 13:12:24 -0700 [thread overview]
Message-ID: <20111031131224.79ca1a2c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110808110658.31053.55013.stgit@localhost6>
On Mon, 8 Aug 2011 15:06:58 +0400
Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> Commit v2.6.33-5448-g6457474 (vmscan: detect mapped file pages used only once)
> greatly decreases lifetime of single-used mapped file pages.
> Unfortunately it also decreases life time of all shared mapped file pages.
> Because after commit v2.6.28-6130-gbf3f3bc (mm: don't mark_page_accessed in fault path)
> page-fault handler does not mark page active or even referenced.
>
> Thus page_check_references() activates file page only if it was used twice while
> it stays in inactive list, meanwhile it activates anon pages after first access.
> Inactive list can be small enough, this way reclaimer can accidentally
> throw away any widely used page if it wasn't used twice in short period.
>
> After this patch page_check_references() also activate file mapped page at first
> inactive list scan if this page is already used multiple times via several ptes.
We have quite a few acks on these two patches, but everyone wants to
see detailed performance testing. That hasn't happened, and caution
dictates that I hold these patches out of linux-3.2, pending that
testing.
Of course, you're not the only person who can undertake that testing (hint).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-10-31 20:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 11:06 [PATCH 1/2] vmscan: promote shared file mapped pages Konstantin Khlebnikov
2011-08-08 11:07 ` [PATCH 2/2] vmscan: activate executable pages after first usage Konstantin Khlebnikov
2011-08-08 23:58 ` KAMEZAWA Hiroyuki
2011-08-09 0:02 ` Minchan Kim
2011-08-09 0:04 ` KAMEZAWA Hiroyuki
2011-08-09 0:26 ` Minchan Kim
2011-08-09 1:23 ` Shaohua Li
2011-08-08 11:37 ` [PATCH 1/2] vmscan: promote shared file mapped pages Pekka Enberg
2011-08-08 12:18 ` Konstantin Khlebnikov
2011-08-08 12:40 ` Pekka Enberg
2011-08-08 12:51 ` Konstantin Khlebnikov
2011-08-18 9:09 ` Johannes Weiner
2011-11-02 16:30 ` Johannes Weiner
2011-11-02 16:31 ` [rfc 1/3] mm: vmscan: never swap under low memory pressure Johannes Weiner
2011-11-02 17:54 ` KOSAKI Motohiro
2011-11-03 15:51 ` Johannes Weiner
2011-11-08 0:16 ` KOSAKI Motohiro
2011-11-07 2:29 ` KAMEZAWA Hiroyuki
2011-11-10 15:29 ` Johannes Weiner
2011-11-02 16:32 ` [rfc 2/3] mm: vmscan: treat inactive cycling as neutral Johannes Weiner
2011-11-02 18:04 ` KOSAKI Motohiro
2011-11-03 12:49 ` Johannes Weiner
2011-11-07 2:34 ` KAMEZAWA Hiroyuki
2011-11-10 16:06 ` Johannes Weiner
2011-11-11 0:05 ` KAMEZAWA Hiroyuki
2011-11-02 16:32 ` [rfc 3/3] mm: vmscan: revert file list boost on lru addition Johannes Weiner
2011-11-07 2:45 ` KAMEZAWA Hiroyuki
2011-11-10 16:12 ` Johannes Weiner
2011-11-02 16:35 ` [PATCH 1/2] vmscan: promote shared file mapped pages Johannes Weiner
2011-08-08 23:36 ` Minchan Kim
2011-08-08 23:51 ` KAMEZAWA Hiroyuki
2011-10-31 20:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031131224.79ca1a2c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).