From: Johannes Weiner <jweiner@redhat.com>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fadvise: only initiate writeback for specified range with FADV_DONTNEED
Date: Tue, 1 Nov 2011 16:05:55 +0100 [thread overview]
Message-ID: <20111101150555.GC19965@redhat.com> (raw)
In-Reply-To: <1320077819-1494-1-git-send-email-sbohrer@rgmadvisors.com>
On Mon, Oct 31, 2011 at 11:16:59AM -0500, Shawn Bohrer wrote:
> Previously POSIX_FADV_DONTNEED would start writeback for the entire file
> when the bdi was not write congested. This negatively impacts
> performance if the file contians dirty pages outside of the requested
> range. This change uses __filemap_fdatawrite_range() to only initiate
> writeback for the requested range.
>
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
It probably makes sense for some cases to take advantage of the disk
head being nearby and flush more than requested.
But I can certainly see this go wrong by taking away the write-caching
benefits for the rest of the file just because a small part of it was
fadvised.
Acked-by: Johannes Weiner <jweiner@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-01 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 16:16 [PATCH] fadvise: only initiate writeback for specified range with FADV_DONTNEED Shawn Bohrer
2011-11-01 15:05 ` Johannes Weiner [this message]
2011-11-22 23:01 ` [PATCH resend] " Shawn Bohrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101150555.GC19965@redhat.com \
--to=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sbohrer@rgmadvisors.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).