From: Andrea Arcangeli <aarcange@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/5]thp: improve the error code path
Date: Thu, 10 Nov 2011 04:06:47 +0100 [thread overview]
Message-ID: <20111110030646.GT5075@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111091828500.32414@chino.kir.corp.google.com>
On Wed, Nov 09, 2011 at 06:43:58PM -0800, David Rientjes wrote:
> You're right, but I agree that the #ifdef's just make the function error
> handling much too complex. Would you mind adding sysfs_*_out labels at
> the end of the function to handle these errors instead? And I think we
> should be doing khugepaged_slab_init() and mm_slots_hash_init() before
> initializing sysfs.
>
> Something like
>
> out:
> khugepaged_slab_free();
> mm_slots_hash_free(); <-- after you remove it from #if 0
> return err;
>
> #ifdef CONFIG_SYSFS
> sysfs_khugepaged_out:
> sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> sysfs_hugepage_out:
> sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> ...
> goto out;
> #endif
Before after won't matter much I guess... If you really want to clean
the code, I wonder what is exactly the point of those dummy functions
if we can't call those outside of #ifdefs. I mean a cleanup that adds
more #ifdefs when there are explicit dummy functions which I assume
are meant to be used outside of #ifdef CONFIG_SYSFS doesn't sound so
clean in the first place. I understand you need to refactor the code
above to call those outside of #ifdefs but hey if you're happy with
#ifdef I'm happy too :). It just looks fishy to read sysfs.h dummy
functions and #ifdefs. When I wrote the code I hardly could have
wondered about the sysfs #ifdefs but at this point it's only cleanups
I'm seeing so I actually noticed that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-10 3:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 2:58 [patch 1/5]thp: improve the error code path Shaohua Li
2011-10-25 11:44 ` Andrea Arcangeli
2011-10-26 1:48 ` Shaohua Li
2011-11-07 5:17 ` Shaohua Li
2011-11-10 2:18 ` Andrea Arcangeli
2011-11-10 2:33 ` Shaohua Li
2011-11-10 2:43 ` David Rientjes
2011-11-10 3:06 ` Andrea Arcangeli [this message]
2011-11-10 4:43 ` David Rientjes
2011-11-10 5:56 ` Shaohua Li
2011-11-10 6:08 ` David Rientjes
2011-11-10 6:27 ` Shaohua Li
2011-11-10 14:14 ` Andrea Arcangeli
2011-11-11 6:33 ` Shaohua Li
2011-11-11 6:50 ` Andrea Arcangeli
2011-11-10 2:59 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110030646.GT5075@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).