From: Andrea Arcangeli <aarcange@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Andy Isaacson <adi@hexapodia.org>,
Johannes Weiner <jweiner@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Do not stall in synchronous compaction for THP allocations
Date: Thu, 10 Nov 2011 15:00:37 +0100 [thread overview]
Message-ID: <20111110140037.GV5075@redhat.com> (raw)
In-Reply-To: <20111110100616.GD3083@suse.de>
On Thu, Nov 10, 2011 at 10:06:16AM +0000, Mel Gorman wrote:
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 963c5de..cddc2d0 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2213,7 +2213,13 @@ rebalance:
> sync_migration);
> if (page)
> goto got_pg;
> - sync_migration = true;
> +
> + /*
> + * Do not use sync migration for transparent hugepage allocations as
> + * it could stall writing back pages which is far worse than simply
> + * failing to promote a page.
> + */
> + sync_migration = !(gfp_mask & __GFP_NO_KSWAPD);
>
> /* Try direct reclaim and then allocating */
> page = __alloc_pages_direct_reclaim(gfp_mask, order,
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-10 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 10:06 [PATCH] mm: Do not stall in synchronous compaction for THP allocations Mel Gorman
2011-11-10 10:38 ` Johannes Weiner
2011-11-10 10:51 ` Alan Cox
2011-11-10 12:06 ` Johannes Weiner
2011-11-10 14:00 ` Andrea Arcangeli [this message]
2011-11-10 14:22 ` Mel Gorman
2011-11-10 15:12 ` Minchan Kim
2011-11-10 16:13 ` Mel Gorman
2011-11-10 16:30 ` Minchan Kim
2011-11-10 16:48 ` Mel Gorman
2011-11-10 23:12 ` Andrew Morton
2011-11-10 23:37 ` David Rientjes
2011-11-11 10:14 ` Mel Gorman
2011-11-11 10:39 ` David Rientjes
2011-11-11 11:17 ` Mel Gorman
2011-11-11 14:21 ` Andrea Arcangeli
2011-11-14 23:44 ` Andrew Morton
2011-11-15 13:25 ` Mel Gorman
2011-11-15 21:07 ` David Rientjes
2011-11-15 23:48 ` Mel Gorman
2011-11-16 0:07 ` David Rientjes
2011-11-16 4:13 ` Andrea Arcangeli
2011-11-16 13:30 ` Andrea Arcangeli
2011-11-16 15:07 ` Mel Gorman
2011-11-18 17:59 ` Andrea Arcangeli
2011-11-16 14:14 ` Mel Gorman
2011-11-11 10:01 ` Mel Gorman
2011-11-15 0:03 ` Andrew Morton
2011-11-15 2:00 ` Andrea Arcangeli
2011-11-15 2:08 ` Andrea Arcangeli
2011-11-15 15:01 ` Mel Gorman
2011-11-15 15:00 ` Mel Gorman
2011-11-15 13:07 ` Mel Gorman
2011-11-15 15:47 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110140037.GV5075@redhat.com \
--to=aarcange@redhat.com \
--cc=adi@hexapodia.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).