linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [patch 2/5]thp: remove unnecessary tlb flush for mprotect
@ 2011-10-25  2:59 Shaohua Li
  2011-11-10 15:23 ` Andrea Arcangeli
  0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2011-10-25  2:59 UTC (permalink / raw)
  To: Andrew Morton; +Cc: aarcange, Hugh Dickins, linux-mm, lkml

change_protection() will do TLB flush later, don't need duplicate tlb flush.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
 mm/huge_memory.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux/mm/huge_memory.c
===================================================================
--- linux.orig/mm/huge_memory.c	2011-10-24 19:24:31.000000000 +0800
+++ linux/mm/huge_memory.c	2011-10-24 19:25:10.000000000 +0800
@@ -1079,7 +1079,6 @@ int change_huge_pmd(struct vm_area_struc
 			entry = pmd_modify(entry, newprot);
 			set_pmd_at(mm, addr, pmd, entry);
 			spin_unlock(&vma->vm_mm->page_table_lock);
-			flush_tlb_range(vma, addr, addr + HPAGE_PMD_SIZE);
 			ret = 1;
 		}
 	} else


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2/5]thp: remove unnecessary tlb flush for mprotect
  2011-10-25  2:59 [patch 2/5]thp: remove unnecessary tlb flush for mprotect Shaohua Li
@ 2011-11-10 15:23 ` Andrea Arcangeli
  0 siblings, 0 replies; 2+ messages in thread
From: Andrea Arcangeli @ 2011-11-10 15:23 UTC (permalink / raw)
  To: Shaohua Li; +Cc: Andrew Morton, Hugh Dickins, linux-mm, lkml

On Tue, Oct 25, 2011 at 10:59:25AM +0800, Shaohua Li wrote:
> change_protection() will do TLB flush later, don't need duplicate tlb flush.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> ---
>  mm/huge_memory.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux/mm/huge_memory.c
> ===================================================================
> --- linux.orig/mm/huge_memory.c	2011-10-24 19:24:31.000000000 +0800
> +++ linux/mm/huge_memory.c	2011-10-24 19:25:10.000000000 +0800
> @@ -1079,7 +1079,6 @@ int change_huge_pmd(struct vm_area_struc
>  			entry = pmd_modify(entry, newprot);
>  			set_pmd_at(mm, addr, pmd, entry);
>  			spin_unlock(&vma->vm_mm->page_table_lock);
> -			flush_tlb_range(vma, addr, addr + HPAGE_PMD_SIZE);
>  			ret = 1;
>  		}
>  	} else

Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-10 15:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25  2:59 [patch 2/5]thp: remove unnecessary tlb flush for mprotect Shaohua Li
2011-11-10 15:23 ` Andrea Arcangeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).