From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id DADA56B002D for ; Thu, 10 Nov 2011 10:23:15 -0500 (EST) Date: Thu, 10 Nov 2011 16:23:12 +0100 From: Andrea Arcangeli Subject: Re: [patch 2/5]thp: remove unnecessary tlb flush for mprotect Message-ID: <20111110152312.GY5075@redhat.com> References: <1319511565.22361.138.camel@sli10-conroe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1319511565.22361.138.camel@sli10-conroe> Sender: owner-linux-mm@kvack.org List-ID: To: Shaohua Li Cc: Andrew Morton , Hugh Dickins , linux-mm , lkml On Tue, Oct 25, 2011 at 10:59:25AM +0800, Shaohua Li wrote: > change_protection() will do TLB flush later, don't need duplicate tlb flush. > > Signed-off-by: Shaohua Li > --- > mm/huge_memory.c | 1 - > 1 file changed, 1 deletion(-) > > Index: linux/mm/huge_memory.c > =================================================================== > --- linux.orig/mm/huge_memory.c 2011-10-24 19:24:31.000000000 +0800 > +++ linux/mm/huge_memory.c 2011-10-24 19:25:10.000000000 +0800 > @@ -1079,7 +1079,6 @@ int change_huge_pmd(struct vm_area_struc > entry = pmd_modify(entry, newprot); > set_pmd_at(mm, addr, pmd, entry); > spin_unlock(&vma->vm_mm->page_table_lock); > - flush_tlb_range(vma, addr, addr + HPAGE_PMD_SIZE); > ret = 1; > } > } else Reviewed-by: Andrea Arcangeli -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org