From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 4D2406B0069 for ; Thu, 17 Nov 2011 19:23:25 -0500 (EST) Date: Thu, 17 Nov 2011 16:23:22 -0800 From: Andrew Morton Subject: Re: [PATCH] mm: account reaped page cache on inode cache pruning Message-Id: <20111117162322.1c3e3d05.akpm@linux-foundation.org> In-Reply-To: <20111116134713.8933.34389.stgit@zurg> References: <20111116134713.8933.34389.stgit@zurg> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner On Wed, 16 Nov 2011 17:47:13 +0300 Konstantin Khlebnikov wrote: > Inode cache pruning indirectly reclaims page-cache by invalidating mapping pages. > Let's account them into reclaim-state to notice this progress in memory reclaimer. > > Signed-off-by: Konstantin Khlebnikov > --- > fs/inode.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/inode.c b/fs/inode.c > index ee4e66b..1f6c48d 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -692,6 +692,8 @@ void prune_icache_sb(struct super_block *sb, int nr_to_scan) > else > __count_vm_events(PGINODESTEAL, reap); > spin_unlock(&sb->s_inode_lru_lock); > + if (current->reclaim_state) > + current->reclaim_state->reclaimed_slab += reap; > > dispose_list(&freeable); > } hm, yes, I suppose we should. It seems to be cheating to use the "reclaimed_slab" field for this. Perhaps it would be cleaner to add an additional field to reclaim_state for non-slab pages which were also reclaimed. That's a cosmetic thing and I guess we don't need to go that far, not sure... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org