[PATCH] memcg: fix the document of pgpgin/pgpgout

[PATCH] memcg: fix the document of pgpgin/pgpgout

[Ying Han]

The two memcg stats pgpgin/pgpgout have different meaning than the ones in
vmstat, which indicates that we picked a bad naming for them. It might be late
to change the stat name, but better documentation is always helpful.

Signed-off-by: Ying Han <yinghan@google.com>
---
 Documentation/cgroups/memory.txt |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt
index cc0ebc5..eb6a911 100644
--- a/Documentation/cgroups/memory.txt
+++ b/Documentation/cgroups/memory.txt
@@ -386,8 +386,11 @@ memory.stat file includes following statistics
 cache		- # of bytes of page cache memory.
 rss		- # of bytes of anonymous and swap cache memory.
 mapped_file	- # of bytes of mapped file (includes tmpfs/shmem)
-pgpgin		- # of pages paged in (equivalent to # of charging events).
-pgpgout		- # of pages paged out (equivalent to # of uncharging events).
+pgpgin		- # of charging events to the memory cgroup. The charging
+		event happens each time a page is accounted as either mapped
+		anon page(RSS) or cache page(Page Cache) to the cgroup.
+pgpgout		- # of uncharging events to the memory cgroup. The uncharging
+		event happens each time a page is unaccounted from the cgroup.
 swap		- # of bytes of swap usage
 inactive_anon	- # of bytes of anonymous memory and swap cache memory on
 		LRU list.
-- 
1.7.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: fix the document of pgpgin/pgpgout

[KAMEZAWA Hiroyuki]

On Mon, 21 Nov 2011 16:48:45 -0800
Ying Han <yinghan@google.com> wrote:

> The two memcg stats pgpgin/pgpgout have different meaning than the ones in
> vmstat, which indicates that we picked a bad naming for them. It might be late
> to change the stat name, but better documentation is always helpful.
> 
> Signed-off-by: Ying Han <yinghan@google.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: fix the document of pgpgin/pgpgout

[Johannes Weiner]

On Mon, Nov 21, 2011 at 04:48:45PM -0800, Ying Han wrote:
> The two memcg stats pgpgin/pgpgout have different meaning than the ones in
> vmstat, which indicates that we picked a bad naming for them. It might be late
> to change the stat name, but better documentation is always helpful.
> 
> Signed-off-by: Ying Han <yinghan@google.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: fix the document of pgpgin/pgpgout

[Michal Hocko]

On Mon 21-11-11 16:48:45, Ying Han wrote:
> The two memcg stats pgpgin/pgpgout have different meaning than the ones in
> vmstat, which indicates that we picked a bad naming for them. It might be late
> to change the stat name, but better documentation is always helpful.
> 
> Signed-off-by: Ying Han <yinghan@google.com>

If not too late
Acked-by: Michal Hocko <mhocko@suse.cz>

> ---
>  Documentation/cgroups/memory.txt |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt
> index cc0ebc5..eb6a911 100644
> --- a/Documentation/cgroups/memory.txt
> +++ b/Documentation/cgroups/memory.txt
> @@ -386,8 +386,11 @@ memory.stat file includes following statistics
>  cache		- # of bytes of page cache memory.
>  rss		- # of bytes of anonymous and swap cache memory.
>  mapped_file	- # of bytes of mapped file (includes tmpfs/shmem)
> -pgpgin		- # of pages paged in (equivalent to # of charging events).
> -pgpgout		- # of pages paged out (equivalent to # of uncharging events).
> +pgpgin		- # of charging events to the memory cgroup. The charging
> +		event happens each time a page is accounted as either mapped
> +		anon page(RSS) or cache page(Page Cache) to the cgroup.
> +pgpgout		- # of uncharging events to the memory cgroup. The uncharging
> +		event happens each time a page is unaccounted from the cgroup.
>  swap		- # of bytes of swap usage
>  inactive_anon	- # of bytes of anonymous memory and swap cache memory on
>  		LRU list.
> -- 
> 1.7.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>