From: Andrew Morton <akpm@linux-foundation.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [patch v2 3/4]thp: add tlb_remove_pmd_tlb_entry
Date: Tue, 22 Nov 2011 15:07:58 -0800 [thread overview]
Message-ID: <20111122150758.b05d90d9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1321340658.22361.296.camel@sli10-conroe>
On Tue, 15 Nov 2011 15:04:18 +0800
Shaohua Li <shaohua.li@intel.com> wrote:
> --- linux.orig/include/asm-generic/tlb.h 2011-11-15 09:39:11.000000000 +0800
> +++ linux/include/asm-generic/tlb.h 2011-11-15 09:39:23.000000000 +0800
> @@ -139,6 +139,20 @@ static inline void tlb_remove_page(struc
> __tlb_remove_tlb_entry(tlb, ptep, address); \
> } while (0)
>
> +/**
> + * tlb_remove_pmd_tlb_entry - remember a pmd mapping for later tlb invalidation
> + * This is a nop so far, because only x86 needs it.
> + */
> +#ifndef __tlb_remove_pmd_tlb_entry
> +#define __tlb_remove_pmd_tlb_entry(tlb, pmdp, address) do {} while (0)
> +#endif
> +
> +#define tlb_remove_pmd_tlb_entry(tlb, pmdp, address) \
> + do { \
> + tlb->need_flush = 1; \
> + __tlb_remove_pmd_tlb_entry(tlb, pmdp, address); \
> + } while (0)
> +
Is there any reason why we cannot implement tlb_remove_pmd_tlb_entry()
as a nice, typesafe C function?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-22 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 7:04 [patch v2 3/4]thp: add tlb_remove_pmd_tlb_entry Shaohua Li
2011-11-15 18:17 ` Andrea Arcangeli
2011-11-22 23:07 ` Andrew Morton [this message]
2011-11-23 3:29 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122150758.b05d90d9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).