From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Christoph Lameter <cl@linux.com>,
Chris Metcalf <cmetcalf@tilera.com>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v4 2/5] arm: Move arm over to generic on_each_cpu_mask
Date: Tue, 22 Nov 2011 21:00:18 +0000 [thread overview]
Message-ID: <20111122210018.GF9581@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1321960128-15191-3-git-send-email-gilad@benyossef.com>
On Tue, Nov 22, 2011 at 01:08:45PM +0200, Gilad Ben-Yossef wrote:
> -static void on_each_cpu_mask(void (*func)(void *), void *info, int wait,
> - const struct cpumask *mask)
> -{
> - preempt_disable();
> -
> - smp_call_function_many(mask, func, info, wait);
> - if (cpumask_test_cpu(smp_processor_id(), mask))
> - func(info);
> -
> - preempt_enable();
> -}
What hasn't been said in the descriptions (I couldn't find it) is that
there's a semantic change between the new generic version and this version -
that is, we run the function with IRQs disabled on the local CPU, whereas
the version above runs it with IRQs potentially enabled.
Luckily, for TLB flushing this is probably not a problem, but it's
something that should've been pointed out in the patch description.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-22 21:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:08 [PATCH v4 0/5] Reduce cross CPU IPI interference Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 1/5] smp: Introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 2/5] arm: Move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2011-11-22 21:00 ` Russell King - ARM Linux [this message]
2011-11-23 6:47 ` Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 3/5] tile: Move tile to use " Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 4/5] slub: Only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2011-11-23 6:23 ` Pekka Enberg
2011-11-23 6:57 ` Pekka Enberg
2011-11-23 7:52 ` Gilad Ben-Yossef
2012-01-01 12:41 ` Avi Kivity
2012-01-01 16:12 ` Gilad Ben-Yossef
2012-01-01 16:50 ` Avi Kivity
2012-01-02 11:59 ` Gilad Ben-Yossef
2012-01-02 13:30 ` Avi Kivity
2012-01-08 16:13 ` Gilad Ben-Yossef
2012-01-08 16:15 ` Avi Kivity
2011-11-22 11:08 ` [PATCH v4 5/5] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2011-11-23 7:45 ` Pekka Enberg
2011-12-23 10:28 ` Mel Gorman
2011-12-25 9:39 ` Gilad Ben-Yossef
2011-12-30 15:04 ` Mel Gorman
2011-12-30 15:25 ` Chris Metcalf
2011-12-30 16:08 ` Mel Gorman
2011-12-30 20:29 ` Gilad Ben-Yossef
2012-01-01 8:03 ` Gilad Ben-Yossef
2011-12-30 20:16 ` Gilad Ben-Yossef
2011-11-23 1:36 ` [PATCH v4 0/5] Reduce cross CPU IPI interference Chris Metcalf
2011-11-23 6:52 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122210018.GF9581@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).