From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>,
Andrea Arcangeli <aarcange@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH v2 1/3] mm: more intensive memory corruption debug
Date: Wed, 23 Nov 2011 14:25:56 +0100 [thread overview]
Message-ID: <20111123132555.GB7943@redhat.com> (raw)
In-Reply-To: <20111122135608.42686f14.akpm@linux-foundation.org>
On Tue, Nov 22, 2011 at 01:56:08PM -0800, Andrew Morton wrote:
> On Fri, 18 Nov 2011 17:25:05 +0100
> Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> I added this:
>
> The default value of debug_guardpage_minorder is zero: no change
> from current behaviour.
>
> correct?
Yes,
> > +static inline void clear_page_guard_flg(struct page *page)
> > +{
> > + __clear_bit(PAGE_DEBUG_FLAG_GUARD, &page->debug_flags);
> > +}
>
> Why is it safe to use the non-atomic bitops here.
Clearing/setting flag is done only in __free_one_page()/expand(),
so operations are protected by zone->lock.
> Please verify that CONFIG_WANT_PAGE_DEBUG_FLAGS is always reliably
> enabled when this feature is turned on.
Change in mm/Kconfig.debug assures that CONFIG_WANT_PAGE_DEBUG_FLAGS is
set whenever CONFIG_DEBUG_PAGEALLOC is.
> Some changes I made - please review.
Look good, thanks Andrew!
Stanislaw
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-11-23 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 16:25 [PATCH v2 1/3] mm: more intensive memory corruption debug Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v2 2/3] PM / Hibernate : do not count debug pages as savable Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v3 3/3] slub: min order when debug_guardpage_minorder > 0 Stanislaw Gruszka
2011-11-21 17:15 ` Christoph Lameter
2011-12-07 22:07 ` David Rientjes
2011-12-08 7:33 ` Stanislaw Gruszka
2011-12-08 21:06 ` David Rientjes
2011-12-12 14:59 ` [PATCH -mm] slub: document setting min order with " Stanislaw Gruszka
2011-12-12 23:21 ` Rafael J. Wysocki
2011-12-14 0:41 ` David Rientjes
2011-12-16 13:21 ` Stanislaw Gruszka
2011-12-16 13:23 ` [PATCH -mm] slub: debug_guardpage_minorder documentation tweak Stanislaw Gruszka
2011-12-16 21:16 ` David Rientjes
2012-01-06 17:52 ` David Rientjes
2011-11-22 21:56 ` [PATCH v2 1/3] mm: more intensive memory corruption debug Andrew Morton
2011-11-23 13:25 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123132555.GB7943@redhat.com \
--to=sgruszka@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).