From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 465736B0096 for ; Thu, 24 Nov 2011 02:04:17 -0500 (EST) Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Nov 2011 00:04:15 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAO743RW124072 for ; Thu, 24 Nov 2011 00:04:04 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAO742ki026688 for ; Thu, 24 Nov 2011 00:04:03 -0700 Date: Thu, 24 Nov 2011 12:33:03 +0530 From: Srikar Dronamraju Subject: Re: Fwd: uprobes: register/unregister probes. Message-ID: <20111124070303.GB28065@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <603b0079-5f54-4299-9a9a-a5e237ccca73@l23g2000pro.googlegroups.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <603b0079-5f54-4299-9a9a-a5e237ccca73@l23g2000pro.googlegroups.com> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra , Linus Torvalds Cc: Oleg Nesterov , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , tulasidhard@gmail.com > On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote: > > +int register_uprobe(struct inode *inode, loff_t offset, > > + struct uprobe_consumer *consumer) > > +{ > > + struct uprobe *uprobe; > > + int ret = -EINVAL; > > + > > + if (!consumer || consumer->next) > > + return ret; > > + > > + inode = igrab(inode); > > So why are you dealing with !consumer but not with !inode? and why > does > it make sense to allow !consumer at all? > I am not sure if I got your comment correctly. I do check for inode just after the igrab. I am actually not dealing with !consumer. If the consumer is NULL, then we dont have any handler to run so why would we want to register such a probe? Also if consumer->next is Non-NULL, that means that this consumer was already used. Reusing the consumer, can result in consumers list getting broken into two. If you meant something else please clarify. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org