From: Mel Gorman <mgorman@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [patch] mm, debug: test for online nid when allocating on single node
Date: Thu, 24 Nov 2011 09:52:06 +0000 [thread overview]
Message-ID: <20111124095205.GQ19415@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221724550.18644@chino.kir.corp.google.com>
On Tue, Nov 22, 2011 at 05:26:05PM -0800, David Rientjes wrote:
> Calling alloc_pages_exact_node() means the allocation only passes the
> zonelist of a single node into the page allocator. If that node isn't
> online, it's zonelist may never have been initialized causing a strange
> oops that may not immediately be clear.
>
> I recently debugged an issue where node 0 wasn't online and an allocator
> was passing 0 to alloc_pages_exact_node() and it resulted in a NULL
> pointer on zonelist->_zoneref. If CONFIG_DEBUG_VM is enabled, though, it
> would be nice to catch this a bit earlier.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Out of curiousity, who was passing in the ID of an offline node to
alloc_pages_exact_node() ?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-24 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 1:26 [patch] mm, debug: test for online nid when allocating on single node David Rientjes
2011-11-24 9:52 ` Mel Gorman [this message]
2011-11-28 10:15 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124095205.GQ19415@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).