From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 34F3D6B0098 for ; Thu, 24 Nov 2011 08:12:37 -0500 (EST) Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Nov 2011 18:20:14 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAOCngbv3313828 for ; Thu, 24 Nov 2011 18:19:43 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAOCnenr022173 for ; Thu, 24 Nov 2011 18:19:42 +0530 Date: Thu, 24 Nov 2011 18:20:15 +0530 From: Srikar Dronamraju Subject: Re: [PATCH v7 3.2-rc2 5/30] uprobes: copy of the original instruction. Message-ID: <20111124182015.4ef4b86a.srikar@linux.vnet.ibm.com> In-Reply-To: <1322073616.14799.96.camel@twins> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111118110733.10512.11835.sendpatchset@srdronam.in.ibm.com> <1322073616.14799.96.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Linus Torvalds , Oleg Nesterov , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson On Wed, 23 Nov 2011 19:40:16 +0100 Peter Zijlstra wrote: > On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote: > > + /* TODO : Analysis and verification of instruction > > */ > > As in refuse to set a breakpoint on an instruction we can't deal with? > > Do we care? The worst case we'll crash the program, but if we're > allowed setting uprobes we already have enough privileges to do that > anyway, right? > I think we should and we do care. That's already implemented in the subsequent patches too. For example: we don't a trace breakpoint instruction. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org