linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH -mm] slub: document setting min order with debug_guardpage_minorder > 0
Date: Tue, 13 Dec 2011 00:21:41 +0100	[thread overview]
Message-ID: <201112130021.41429.rjw@sisk.pl> (raw)
In-Reply-To: <20111212145948.GA2380@redhat.com>

On Monday, December 12, 2011, Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> English is hard (definitely harder than C language :-), so please correct
> me, if I wrote something wrong.
> 
>  Documentation/ABI/testing/sysfs-kernel-slab |    4 +++-
>  Documentation/vm/slub.txt                   |    4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-kernel-slab b/Documentation/ABI/testing/sysfs-kernel-slab
> index 8b093f8..d84ca80 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-slab
> +++ b/Documentation/ABI/testing/sysfs-kernel-slab
> @@ -345,7 +345,9 @@ Description:
>  		allocated.  It is writable and can be changed to increase the
>  		number of objects per slab.  If a slab cannot be allocated
>  		because of fragmentation, SLUB will retry with the minimum order
> -		possible depending on its characteristics.
> +		possible depending on its characteristics. 

Added trailing whitespace (please remove).

> +		When debug_guardpage_minorder > 0 parameter is specified, the
> +		minimum possible order is used and cannot be changed.

Well, I'm not sure what you wanted to say, actually?  How does one change
debug_guardpage_minorder (or specify it), for example?  Is it a kernel
command-line switch?

Also I'm not sure what "cannot be changed" is supposed to mean.  Does it
mean that /sys/cache/slab/cache/order has no effect in that case?

>  
>  What:		/sys/kernel/slab/cache/order_fallback
>  Date:		April 2008
> diff --git a/Documentation/vm/slub.txt b/Documentation/vm/slub.txt
> index f464f47..dbf02ad 100644
> --- a/Documentation/vm/slub.txt
> +++ b/Documentation/vm/slub.txt
> @@ -131,7 +131,9 @@ slub_min_objects.
>  slub_max_order specified the order at which slub_min_objects should no
>  longer be checked. This is useful to avoid SLUB trying to generate
>  super large order pages to fit slub_min_objects of a slab cache with
> -large object sizes into one high order page.
> +large object sizes into one high order page. Setting parameter
> +debug_guardpage_minorder > 0 forces setting slub_max_order to 0, what
> +cause minimum possible order of slabs allocation.
>  
>  SLUB Debug output
>  -----------------
> 

Rafael

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-12-12 23:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 16:25 [PATCH v2 1/3] mm: more intensive memory corruption debug Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v2 2/3] PM / Hibernate : do not count debug pages as savable Stanislaw Gruszka
2011-11-18 16:25 ` [PATCH v3 3/3] slub: min order when debug_guardpage_minorder > 0 Stanislaw Gruszka
2011-11-21 17:15   ` Christoph Lameter
2011-12-07 22:07   ` David Rientjes
2011-12-08  7:33     ` Stanislaw Gruszka
2011-12-08 21:06       ` David Rientjes
2011-12-12 14:59         ` [PATCH -mm] slub: document setting min order with " Stanislaw Gruszka
2011-12-12 23:21           ` Rafael J. Wysocki [this message]
2011-12-14  0:41             ` David Rientjes
2011-12-16 13:21               ` Stanislaw Gruszka
2011-12-16 13:23                 ` [PATCH -mm] slub: debug_guardpage_minorder documentation tweak Stanislaw Gruszka
2011-12-16 21:16                   ` David Rientjes
2012-01-06 17:52                     ` David Rientjes
2011-11-22 21:56 ` [PATCH v2 1/3] mm: more intensive memory corruption debug Andrew Morton
2011-11-23 13:25   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112130021.41429.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rientjes@google.com \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).