From: Michal Hocko <mhocko@suse.cz>
To: Ying Han <yinghan@google.com>
Cc: Balbir Singh <bsingharora@gmail.com>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Pavel Emelyanov <xemul@openvz.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Greg Thelen <gthelen@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] memcg: Use gfp_mask __GFP_NORETRY in try charge
Date: Tue, 13 Dec 2011 17:25:31 +0100 [thread overview]
Message-ID: <20111213162531.GF30440@tiehlicka.suse.cz> (raw)
In-Reply-To: <20111213162126.GE30440@tiehlicka.suse.cz>
On Tue 13-12-11 17:21:26, Michal Hocko wrote:
> On Mon 12-12-11 18:16:27, Ying Han wrote:
> > In __mem_cgroup_try_charge() function, the parameter "oom" is passed from the
> > caller indicating whether or not the charge should enter memcg oom kill. In
> > fact, we should be able to eliminate that by using the existing gfp_mask and
> > __GFP_NORETRY flag.
> >
> > This patch removed the "oom" parameter, and add the __GFP_NORETRY flag into
> > gfp_mask for those doesn't want to enter memcg oom. There is no functional
> > change for those setting false to "oom" like mem_cgroup_move_parent(), but
> > __GFP_NORETRY now is checked for those even setting true to "oom".
> >
> > The __GFP_NORETRY is used in page allocator to bypass retry and oom kill. I
> > believe there is a reason for callers to use that flag, and in memcg charge
> > we need to respect it as well.
>
> What is the reason for this change?
Ahh, just noticed the second patch. Give me some time to think about
that.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-13 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 2:16 [PATCH 1/2] memcg: Use gfp_mask __GFP_NORETRY in try charge Ying Han
2011-12-13 4:29 ` KAMEZAWA Hiroyuki
2011-12-13 16:21 ` Michal Hocko
2011-12-13 16:25 ` Michal Hocko [this message]
2011-12-13 18:43 ` Ying Han
2011-12-14 10:46 ` Michal Hocko
2011-12-14 23:59 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213162531.GF30440@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=bsingharora@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=xemul@openvz.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).