From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jesper Juhl <jj@chaosbits.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Put braces around potentially empty 'if' body in handle_pte_fault()
Date: Sun, 18 Dec 2011 00:34:19 +0000 [thread overview]
Message-ID: <20111218003419.GE2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1324167535.3323.63.camel@edumazet-laptop>
On Sun, Dec 18, 2011 at 01:18:55AM +0100, Eric Dumazet wrote:
> Thats should be fixed in the reverse way :
>
> #define flush_tlb_fix_spurious_fault(vma, address) do { } while (0)
There's a better way to do that -
#define f(a) do { } while(0)
does not work as a function returning void -
f(1), g();
won't work. OTOH
#define f(a) ((void)0)
works just fine.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-18 0:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 0:03 [PATCH] Put braces around potentially empty 'if' body in handle_pte_fault() Jesper Juhl
2011-12-18 0:18 ` Eric Dumazet
2011-12-18 0:26 ` Jesper Juhl
2011-12-18 0:34 ` Al Viro [this message]
2011-12-18 1:18 ` Alexey Dobriyan
2011-12-19 22:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111218003419.GE2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hughd@google.com \
--cc=jj@chaosbits.net \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).