From: Andrea Arcangeli <aarcange@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/3] pagemap: export KPF_THP
Date: Mon, 19 Dec 2011 20:05:14 +0100 [thread overview]
Message-ID: <20111219190514.GN16411@redhat.com> (raw)
In-Reply-To: <20111219184047.GA5637@one.firstfloor.org>
On Mon, Dec 19, 2011 at 07:40:47PM +0100, Andi Kleen wrote:
> > diff --git 3.2-rc5.orig/fs/proc/page.c 3.2-rc5/fs/proc/page.c
> > index 6d8e6a9..d436fc6 100644
> > --- 3.2-rc5.orig/fs/proc/page.c
> > +++ 3.2-rc5/fs/proc/page.c
> > @@ -116,6 +116,11 @@ u64 stable_page_flags(struct page *page)
> > if (PageHuge(page))
> > u |= 1 << KPF_HUGE;
> >
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > + if (PageTransCompound(page))
> > + u |= 1 << KPF_THP;
> > +#endif
>
> It would be better to have PageTransCompound be a dummy (always 0)
> for !CONFIG_TRANSPARENT_HUGEPAGE and KPF_THP always defined.
It's already the case, that's the whole point of using
PageTransCompound instead of PageCompound (the former defines to 0 is
the config option is disabled).
> This would keep ifdefery in the headers.
Yes the #ifdef can go already.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-19 19:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 18:38 [RFC][PATCH 0/3] pagemap handles transparent hugepage Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 1/3] pagemap: avoid splitting thp when reading /proc/pid/pagemap Naoya Horiguchi
2011-12-19 18:45 ` Andi Kleen
2011-12-19 18:48 ` David Rientjes
2011-12-19 19:16 ` Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 2/3] pagemap: export KPF_THP Naoya Horiguchi
2011-12-19 18:40 ` Andi Kleen
2011-12-19 18:49 ` David Rientjes
2011-12-19 18:55 ` Naoya Horiguchi
2011-12-19 19:05 ` Andrea Arcangeli [this message]
2011-12-19 19:24 ` KOSAKI Motohiro
2011-12-19 20:26 ` Naoya Horiguchi
2011-12-19 20:48 ` KOSAKI Motohiro
2011-12-19 21:20 ` Naoya Horiguchi
2011-12-19 20:31 ` Dave Hansen
2011-12-19 20:45 ` KOSAKI Motohiro
2011-12-19 20:57 ` Dave Hansen
2011-12-19 21:23 ` Andrea Arcangeli
2011-12-20 3:35 ` Wu Fengguang
2011-12-20 18:10 ` Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 3/3] pagemap: document KPF_THP and show make page-types aware of it Naoya Horiguchi
2011-12-19 18:51 ` David Rientjes
2011-12-20 3:41 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219190514.GN16411@redhat.com \
--to=aarcange@redhat.com \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).