From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: hannes@cmpxchg.org, hughd@google.com,
kamezawa.hiroyu@jp.fujitsu.com, mszeredi@suse.cz,
yinghan@google.com, linux-mm@kvack.org
Subject: Re: + memcg-clear-pc-mem_cgorup-if-necessary-fix-2-fix.patch added to -mm tree
Date: Wed, 21 Dec 2011 01:41:38 -0800 [thread overview]
Message-ID: <20111221014138.45192a39.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111221093547.GC27137@tiehlicka.suse.cz>
On Wed, 21 Dec 2011 10:35:47 +0100 Michal Hocko <mhocko@suse.cz> wrote:
> On Tue 20-12-11 15:30:36, Andrew Morton wrote:
> >
> > The patch titled
> > Subject: memcg-clear-pc-mem_cgorup-if-necessary-fix-2-fix
> > has been added to the -mm tree. Its filename is
> > memcg-clear-pc-mem_cgorup-if-necessary-fix-2-fix.patch
> >
> > Before you just go and hit "reply", please:
> > a) Consider who else should be cc'ed
> > b) Prefer to cc a suitable mailing list as well
> > c) Ideally: find the original patch on the mailing list and do a
> > reply-to-all to that, adding suitable additional cc's
> >
> > *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >
> > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> > out what to do about this
> >
> > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> >
> > ------------------------------------------------------
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: memcg-clear-pc-mem_cgorup-if-necessary-fix-2-fix
> >
> > ksm.c needs memcontrol.h, per Michal
>
> Just for record. It really doesn't need it at the moment because it gets
> memcontrol.h via rmap.h resp. swap.h but I plan to remove memcontrol
> include from those two.
> I can do that in a separate patch if you prefer?
Sure. It's generally bad to rely upon nested includes, especially one
which the outer header file included for its own purposes (which might
change).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-12-21 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111220233037.47879100052@wpzn3.hot.corp.google.com>
2011-12-21 9:35 ` + memcg-clear-pc-mem_cgorup-if-necessary-fix-2-fix.patch added to -mm tree Michal Hocko
2011-12-21 9:41 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221014138.45192a39.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mszeredi@suse.cz \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).